Error on SQL Server 2008 and datetime2 about odbc HOT 8 CLOSED

I don't have SQL Server 2008. Let me find one, so I can investigate this. But, 
please, send the change, if you like. Thank you.

Alex

Luke,

I issued these

select cast('20151225' as datetime)
select cast('20151225' as datetime2)

and here is what SQLDescribeCol returns

datetime : sqltype=93 size=23 decimal=3
datetime2: sqltype=-9 size=27 decimal=0

so datetime2 is returned as just SQL_WVARCHAR (it is a simple string). Do you 
see things any different?

As to parameters, I didn't try anything. Instead I have found this

http://stackoverflow.com/questions/6256302/how-to-bind-a-value-to-a-stored-proc-
parameter-of-type-datetime27-using-odbc?rq=1

which kind of repeat what you said. datetime parameter code is already has some 
hardcoding, I am not sure what to do until I se what your real problem is.

I will wait for you to send some code before decideing what to do next.

Alex

Alex,

Thanks for looking into this.  I think that your driver is returning datetime2 
as a "SQL_WVARCHAR" because you are using an older version of SQL Native Client 
that doesn't support datetime2.  Try upgrading to a more recent version of SQL 
Native Client.  You can try: 
http://www.microsoft.com/en-us/download/details.aspx?id=35580 (Click on 
"Download" and then ENU\x64\sqlncli.msi   Then set your connection string to 
include: "Driver={SQL Server Native Client 11.0}"  After completing that, 
SQLDescribeCol should report SQL_TYPE_TIMESTAMP.  
I read the stackoverflow post and I did something very similar.  In param.go in 
the "time.Time" case I added:
size = 27   // 20 + s (the number of characters in the yyyy-mm-dd 
hh:mm:ss[.fff...] format, where s is the seconds precision).
decimal = 7 //Setting to maximum possible fraction of a second -- cannot 
determine how to read this from api.SQLDescribeParam

I also added a check after the switch to only set the decimal and size if they 
were not set in the switch.  I have attached the file.  I will submit a change 
request if you think it looks good.

Luke,

This https://codereview.appspot.com/13270047/ is to fetch datatime2 types from 
the server. Please, review.

I will do parameter handling later

Alex

Reviewed the change to the tests.

Luke,

I have this test:

diff -r fdeace4e5288 mssql_test.go
--- a/mssql_test.go Wed Sep 04 16:49:55 2013 +1000
+++ b/mssql_test.go Wed Sep 04 17:27:08 2013 +1000
@@ -965,3 +965,53 @@

    exec(t, db, "drop table dbo.temp")
 }
+
+// https://code.google.com/p/odbc/issues/detail?id=14
+func TestMSSQLDatetime2Param(t *testing.T) {
+   db, sc, err := mssqlConnect()
+   if err != nil {
+       t.Fatal(err)
+   }
+   defer closeDB(t, db, sc, sc)
+
+   if !is2008OrLater(db) {
+       t.Skip("skipping test; needs MS SQL Server 2008 or later")
+   }
+
+   db.Exec("drop table dbo.temp")
+   exec(t, db, "create table dbo.temp (dt datetime2)")
+
+   expect := time.Date(2007, 5, 8, 12, 35, 29, 1234567e2, time.Local)
+   _, err = db.Exec("insert into dbo.temp (dt) values (?)", expect)
+   if err != nil {
+       t.Fatal(err)
+   }
+   var got time.Time
+   err = db.QueryRow("select top 1 dt from dbo.temp").Scan(&got)
+   if err != nil {
+       t.Fatal(err)
+   }
+   if expect != got {
+       t.Fatalf("expect %v, but got %v", expect, got)
+   }
+
+   exec(t, db, "drop table dbo.temp")
+}
+

And it is not failing regardless if I make changes to param.go or not. Do you 
have a reproducible test that is broken. Thank you.

Alex

Luke, how about this https://codereview.appspot.com/14426055/ ?

Alex

This issue was closed by revision d05da338d8c0.