Comments (1)
Yeah, the example can be simplified.
However I find that the usage of blocking
is still valuable as it serves documenting purposes.
Plus usually the thread-pool is injected from somewhere, being a bad idea to hard-code it and so it's often a matter of configuration ... change the thread-pool, then it starts working again. Which is why operations that block are error prone, as their correctness depends on the configuration of the underlying thread-pool. Hence clearly seeing in code things that block is very important.
BTW, Await.result
already uses blocking
in its implementation. But then you can also see it clearly that it blocks. So an example using Await.result
is not the most fortunate. But couldn't think of anything better.
from scala-best-practices.
Related Issues (20)
- Writing effective tests? HOT 5
- Use if-else vs pattern matching for booleans HOT 8
- Add rule on not doing TODO comments HOT 1
- Rule 3.1 example? HOT 3
- Add a rule about best / bad practices for implicits and context bounds HOT 7
- Rule about updating a var for loops or conditionals HOT 17
- IMPORTANT: Rewriting history of repository HOT 2
- 3.4. SHOULD be mindful of the garbage collector — Incorrect example HOT 2
- Rule 5.1 needs a *good* example HOT 1
- Scala `return` actually throws `NonLocalReturnControl[A]` now
- 2.17 Nested case classes? HOT 1
- Update rule 2.11 to discourage use of joda-time in favour of java.time HOT 3
- 2.3 Clarity HOT 2
- Reference to JMH, Scala Meter HOT 2
- Add a rule for NOT using Seq.head HOT 1
- explicit section/subsection numbers make it harder to contribute HOT 2
- Add a rule: case classes SHOULD be final HOT 4
- Usage of underscore
- Suggestion SHOULD NOT use scala.App HOT 1
- [question] Usage of return HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scala-best-practices.