Comments (3)
Can we change the below statement
Line 57 in 140a044
to
encoder = encodeURIComponent;
So, it need not to update the major version. While the encoder
as the last parameter is more reasonable.
from tiny-cookie.
I don't see a big issue in major version increment. But if you have any objections (for example if you plan more breaking changes in nearest future, it makes sense to combine them), let's just change this line and update documentation.
Let me know what do you think and I'll create a PR.
from tiny-cookie.
I fixed this bug by changing one line. I'll start to develop the next major version, and you can check the task list #19.
from tiny-cookie.
Related Issues (20)
- undefined when importing via babel HOT 4
- Version 2.0 does not work in IE 11 HOT 3
- Don't use code in `src` folder directly for `module` field in package.json HOT 1
- Can't remove() cookies set on custom domain HOT 1
- Target 3.0 HOT 1
- Support SameSite attribute HOT 2
- Add chinese document
- `es` directory not exported in npm module HOT 2
- Option to set httponly? HOT 3
- Add flowjs types
- Secure / Path options are ignored when removeCookie is called HOT 1
- Set path to root when testing if cookies are enabled HOT 2
- CI tests are failed because of using the deprecated uglify options
- UMD build HOT 1
- Support CookieStore API? HOT 1
- Support pure esm package? HOT 1
- Refactor in typescript HOT 1
- 2.4 version HOT 2
- Warning: To load an ES module issue HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tiny-cookie.