Code Monkey home page Code Monkey logo

Comments (3)

Alex1990 avatar Alex1990 commented on July 29, 2024

Can we change the below statement

encoder = null;

to

encoder = encodeURIComponent;

So, it need not to update the major version. While the encoder as the last parameter is more reasonable.

from tiny-cookie.

boccob avatar boccob commented on July 29, 2024

I don't see a big issue in major version increment. But if you have any objections (for example if you plan more breaking changes in nearest future, it makes sense to combine them), let's just change this line and update documentation.

Let me know what do you think and I'll create a PR.

from tiny-cookie.

Alex1990 avatar Alex1990 commented on July 29, 2024

I fixed this bug by changing one line. I'll start to develop the next major version, and you can check the task list #19.

from tiny-cookie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.