Comments (14)
from hugo-book.
Hi!
I suppose it's due to title not being jsonified as well here: https://github.com/alex-shpak/hugo-book/blob/master/assets/search-data.js#L8
Can you please check place where error given and post it here? Or if your website is public to share a link so I can check it.
Edit: I pushed changes to master, please try now.
from hugo-book.
Changes are now pushed to master
https://raw.githubusercontent.com/alex-shpak/hugo-book/master/images/screenshot.png
Though, there is still room for improvement in future.
from hugo-book.
Hi!
Yes, it would be nice to have, so far I didn't develop vision on best way implementing this, so It's in TODO state.
from hugo-book.
Work is started at feature/search
branch
from hugo-book.
Now I consider two options:
- Keep search bar under site title, and load index on first focus
- Create separate page
/docs/search
to keep all search functionality, to not load lunr and index on each page.
๐ค
from hugo-book.
I'm getting these errors when typing into search bar. Happening in Firefox and Chrome.
Do you know what could be wrong? Thanks.
from hugo-book.
Works flawlessly now! Thank you for a quick fix :)
from hugo-book.
Funnily enough, I ended up setting this up myself from the Hugo Search doc: https://gist.github.com/eddiewebb/735feb48f50f0ddd65ae5606a1cb41ae
Also, the search on the live demo here doesnโt seem to work? Itโs got a readonly
attribute.
https://themes.gohugo.io/theme/hugo-book/
from hugo-book.
Hi Alex,
first of all thank you very much for your excellent work.
I am using tags and categories for my documents and find in the search results links to list pages for categories and tags. So far this is fine. Unfortunately I find after creation of the site in the category and tag folders only xml files but no html files for the category/tag pages. Would it be possible to enhance the theme with the ability to create those pages too?
Furthermore if I could have some more wishes: It would be great if the single pages could append a footer with a table or an unordered list with two bullets. One for categories and one for tags showing the assigened terms as a comma separated and linked list? Finally it would be a great improvement to the search results, when links to category/tag pages could be distinguished from content pages by a marker or label.
from hugo-book.
@jog968 Hi! Thanks,
I think It would be reasonable to create these feature requests as separate issues in github.
In general, main goal of theme is documentation so I added minimal blogging features, but I would say adding tags and categories is ok. Not top priority tho. PRs are welcome :)
On lists with tags and categories, I think it's too specific feature for generic website, I think better is to customize your footer partial and add what you want.
from hugo-book.
@mistermantas Regarding search on themes.gohugo.io, this is absURL
issue, I try to avoid absURL
in theme, but they are required there because each theme is subfolder.
Not sure that I want to introduce absolute link to fix that ๐ค
from hugo-book.
@alex-shpak: Hi and Thanks,
I'm glad to hear that tags and categories can be added. Priority is not so important. I will wait.
Regarding lists I will try to do this by myself. It is time for me to learn some basics.
from hugo-book.
Closing this issue.
from hugo-book.
Related Issues (20)
- Highlighting Color Scheme and Adding Line Numbers to Expand Shortcodes
- Expand shortcode is deprecated. Use 'details' instead. HOT 1
- no such template "_internal/google_analytics_async.html" HOT 1
- IsMultiLingual error on build HOT 5
- Odd menu issue w/ Book upgrade
- youtube in tab broken
- Strange issues on build...
- Edit Page (BookEditPath) function not working for multilanguage projects
- where to hide categories and tages and these three dots?
- blog
- Example for menu with subdirectories
- The table of contents in the Hugo book theme use to much space HOT 2
- It is possible to display more titles in the blog main page? HOT 1
- No Bash syntax highlighting
- Remove persistent "#" symbol on Headers HOT 2
- Why do page titles hyperlink to the very same page?
- Code block line numbers are misaligned
- What if I have more than one book?
- HelloGitHub Badge
- failed to extract shortcode: template for shortcode "hint" not found
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hugo-book.