Comments (2)
I should mention that it takes a certain combination. I've found the bug in this situation:
Test runner calls require("tests/testA")
TestA calls require("../../src/sourceA")
SourceA calls require("./sourceB")
.
Even this case works (with the addition of another custom require loader to the instrumented file),
BUT if sourceA also include: require("./sourceC")
then it doesn't work because the instrumented require gets called recursively.
When SourceA gets instrumented there needs to be some code added I think to make sure that the proper path is passed to the require loader. I'm going to try to write a test to handle this case.
from blanket.
Figured it out.
I can manually insert the correct path during the instrumentation:
instrumented = instrumented.replace(/require\("./g,"require(\""+path.dirname(filename)+"/.").replace(/require\('./g,"require('"+path.dirname(filename)+"/.");
this could be cleaner, maybe even done during the parsing itself, but it accomplishes the task nicely.
from blanket.
Related Issues (20)
- Commented on: Not seeing any reports - noob alert #244 HOT 1
- _$jscoverage is not defined | blanket 1.2.1 HOT 21
- Reason for replacing ".js" with ""
- In ploymer,the script is written in the component html,is there any method to set data-cover on the script HOT 2
- Publish the latest version HOT 1
- Global object replaced on QUnit test
- How to use Blanket.js in test files loaded with Require.js? HOT 2
- blanket js does not given correct results.
- Can blanket handle source maps?
- documention is wrong for using with mocha HOT 1
- Advice on how to use with WebDriver. HOT 1
- Support for phantomjs 2.1.1 (for blanket to work on ppc64le architecture)
- Coverage for hoisted vars HOT 2
- I am getting Error: invalid reporter "html-cov" HOT 1
- Tests stop running on upgrading to [email protected] HOT 1
- make a new release on the github?
- Instrumentation affects test results.
- Running Jasmine Code Coverage using command Line
- Deprecate this?
- Hi
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blanket.