Code Monkey home page Code Monkey logo

Comments (6)

Rosencrantz avatar Rosencrantz commented on August 23, 2024 1

@stchris Says we're done here. Thanks for your help @friendly-wolfbat much appreciated

from aleph.

tillprochaska avatar tillprochaska commented on August 23, 2024

Hi @friendly-wolfbat, thanks for opening this issue. You are correct, the documentation isn’t up to date in this regard. We do plan to address this as part of a larger overhaul of the technical documentation. But this may take some time, so we should probably address the issue you brought up earlier than that.

from aleph.

friendly-wolfbat avatar friendly-wolfbat commented on August 23, 2024

Hi @tillprochaska, thanks for responding. If you can clarify on points 2 and 3 briefly (or link me to some code where I can find the answer), I can put together a pull request for this particular issue to correct the documentation.

from aleph.

stchris avatar stchris commented on August 23, 2024

Hi @friendly-wolfbat , thanks for noticing and for offering to fix this.

  1. You're totally right, we missed a few spots where convert-document is still mentioned.
  2. We have added a section on scaling workers in general here, so it'd be best to link to that.
  3. That's right, that section should stay, because it provides a useful workaround, but the references to the "convert-document service" should probably should just mention "document convert operations" (in ingest-file).

We're very happy to review your contribution as a PR, but otherwise I can take care of these changes, just let me know. Thanks either way!

from aleph.

friendly-wolfbat avatar friendly-wolfbat commented on August 23, 2024

I tried my hand at the PR. I think one piece that I'm missing is, if a user wishes to disable threading, how many workers should they have relative to the number of cores, and how many ingest-file containers should they have relative to the number of cores?

On a separate note, I see that the installation instructions also say, "[f]or the purpose of scaling workers and getting more predictable performance [...]"--does this mean that disabling threading and having more containers is "better" in terms of performance, or just more predictable?

from aleph.

stchris avatar stchris commented on August 23, 2024

Thanks @friendly-wolfbat , I'll reply in the PR.

from aleph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.