Code Monkey home page Code Monkey logo

Comments (9)

GoogleCodeExporter avatar GoogleCodeExporter commented on August 10, 2024
Carlos, i'm forwarding this one to you, if you don't mind taking a look

Original comment by [email protected] on 5 Feb 2010 at 6:20

  • Changed state: Accepted

from gwt-cal.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 10, 2024
A quick reference check showed both gwt datepicker 
(http://screencast.com/t/OGQzNGUzYj) and gxt datepicker 
(http://screencast.com/t/ZWM5ZGQ3) both render 6 row regardless. The real 
google calendar renders 5 when 
needed but the date picker it uses actually always renders 6 rows as well.  If 
it is easier it might be safe to just 
always render 6 rows

Original comment by [email protected] on 5 Feb 2010 at 6:28

from gwt-cal.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 10, 2024
Hey Brad, 

I don't mind at all. I'll look into this today.

Original comment by [email protected] on 5 Feb 2010 at 6:52

from gwt-cal.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 10, 2024
A Bug fix has been checked-in. Apparently the problem was that we were 
calculating
the number of required rows for the first date shown in the calendar instead of 
a
date ON the actual month of interest displayed in the Month View. This was not 
caused
by the MonthViewHelper#monthViewRequiredRows logic but by the date it was 
passed for
the calculation.

Because for some months the first date shown fell within the same month, the 
code
would correctly display the number of rows. For month views showing days from 
the
previous month, it was the number of rows for the PREVIOUS month what was being
displayed and hence the problem.

Snapshots from Firefox Hosted, Firefox Native, Chrome Native (all in Ubuntu 
x64) and
Internet Explorer 7 (Windows Vista 32-bit) are attached for the months shown 
with the
error when the issue was logged (Feb 2010 & May 2010).

CM

Original comment by [email protected] on 7 Feb 2010 at 9:47

Attachments:

from gwt-cal.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 10, 2024
awesome. thanks Carlos!

Original comment by [email protected] on 7 Feb 2010 at 10:06

from gwt-cal.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 10, 2024
Hello d.tangren,

Thank you for your feedback. If you can please let me know whether you find the 
issue
solved in your own environment so I can properly change the status of the 
defect I
would really appreciate it. Thanks for reporting the issue.

Best,

CM

Original comment by [email protected] on 8 Feb 2010 at 1:04

from gwt-cal.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 10, 2024
P.S. I am jealous I don't have a osx snow leopard to test myself. ;)

Original comment by [email protected] on 8 Feb 2010 at 1:06

from gwt-cal.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 10, 2024
Just tested. Works great! Thanks Carlos.

Original comment by [email protected] on 8 Feb 2010 at 2:22

from gwt-cal.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 10, 2024

Original comment by [email protected] on 8 Feb 2010 at 7:33

  • Changed state: Done

from gwt-cal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.