Comments (10)
The fix should be easy to do. Do you need/want a PR ?
from k8s-usenet.
Oh! Good catch!
Yeah let's review all the charts and go ahead and create a PR :)
Thanks
from k8s-usenet.
Here is what I suggest: discussion here on Sonarr chart, through a first version of a PR.
When we're okay on the changes, review of all charts having the same "issue" and 2nd version of the PR with all charts fixed.
Would that work for you?
from k8s-usenet.
Here is a list of the other charts that would need to be fixed the same way (if that's fine for you):
nzbhydra2/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
bazarr/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
lazylibrarian/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
medusa/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
sabnzbd/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
headphones/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
couchpotato/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
radarr/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
mylar/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
transmission/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
lidarr/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
nzbget/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
organizr/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
jackett/templates/deployment.yaml:30: image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
from k8s-usenet.
Ossom @jeje
I already merged the PR (simple and sweet), proceed with the others and many thanks!
from k8s-usenet.
I was about to ensure this fix worked fine (although I'm quite confident :)) before doing the same for the other charts, but I assume that the helm repo is not automatically updated from the master?
from k8s-usenet.
Up until I don't execute the make action it won't update anything on the repository.
So don't worry on that as I'll double check before pushing the red button 👍
from k8s-usenet.
New PR submitted.
I haven't checked though that default tags are available for each chart.
I hope there is amd64-latest
tag for each container :)
from k8s-usenet.
Thanks I'll take a look on the tags and I'll update the PR accordingly (if necessary!)
from k8s-usenet.
PR merged. I'll proceed to close this thread! Thanks @jeje feel free to re-open this one if you detect any issue.
from k8s-usenet.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from k8s-usenet.