Please migrate away from setup.py about clevercsv HOT 6 OPEN

Hi,

I guess this issue could be closed, yes. I would prefer if it wasn't though, as I don't think the current fix is what I intended :)

@SnoopJ is right in correcting me by saying setup.py isn't deprecated itself (only running it as CLI argument to build is). They're also right when they say you can now build this project using python3.11 -m build (I've just tested this while updating the Debian package to 0.8.0).

Most of the logic stays in the setup.py file though, and is in-house code. I think the best practice would be to migrate most (if not all) of that logic in the pyproject.toml file :)

I had a look and it doesn't seem like it would be a lot of work?

from clevercsv.

Point of clarification: setup.py is not itself deprecated (unless I am misinformed, in which case I would appreciate a pointer to the deprecation notice), but running setup.py directly is deprecated. I'm not familiar enough with this project to know if the executable portions of setup.py could be subsumed into an entirely-declarative way (setup.cfg or pyproject.toml) but it would be a good improvement to remove the direct execution of the file from the build tooling. I was able to successfully build this project with build as well as pip wheel, so it is probably compatible with any PEP 517 build front-end.

from clevercsv.

@baldurmen It seems to have been fixed. Can this be closed?

from clevercsv.

Yes you're right, the pyproject.toml is there but the setup.py lingers.

from clevercsv.

Thanks both for the discussion! I looked into this a bit but haven't fully completed the transition. I believe from what I've seen so far that the setup.py file is still needed for some build functionality (such as the C extensions), so my thinking is that in order to resolve this ticket it would be best to have that be the only things that are defined in the setup.py file. Until then I'll leave this ticket open.

from clevercsv.

You can use PDM: https://pdm-backend.fming.dev/build_config/#run-setuptools

from clevercsv.