Code Monkey home page Code Monkey logo

Comments (3)

akmaier avatar akmaier commented on September 28, 2024

As far as I can see, this is only called for MultiChannelGrids. Those are currently only used in material decomposition, multi-energy processing, and image segmentation. As the ImagePlus container is only used to write data to disk or display, I would expect that changing this to the current grid is OK and does not cause any trouble.

However, you need an adopted version anyway as the multichannel data is just a new channel in the same resolution and not a 3D volume. As such the current behaviour should be incorrect anyway. I guess, it was never noticed as it is typically only used for display with ImageJ. I would support fixing this issue.

from conrad.

tmgeimer avatar tmgeimer commented on September 28, 2024

See pull request #141

Multi-channel handling
MultiChannelGrids were indeed not recognized as such.
MultiChannelGrid3D supports multple channels by using an internal Grid4D data member. As such checking the subgrids for instanceof MultiChannelGrid2D was incorrect.
The method now checks the Grid3D directly and extracts information accordingly.

Calibration
The version of setCalibrationToImagePlus without an input grid was removed. Both default and multi-channel grids carry the properties needed to fill the ImagePlus calibration. Consequently, checking the global configuration for this information should not be necessary at all.

from conrad.

tmgeimer avatar tmgeimer commented on September 28, 2024

There are in fact some occasions (e.g. in tutorial.motion.MotionCompensatedReconExample), where Grid3D was used as a container for MultiChannelGrid2D without being multi-channel itself. This required the multi-channel property to be checked on the subGrids. Hence, we re-added (and reworked) this part.
Nevertheless, in case of the Grid3D container, calibration can still be acquired from the 2D subgrids directly using setCalibrationToImagePlus2D. setCalibrationToImagePlus without an input grid remains removed.

With the merge of pull request #141, I'd support closing this issue.

from conrad.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.