Don't automatically skip events that cannot be deserialized about akka-edge-rs HOT 4 CLOSED

Given that the developer is able to take full control of the deserialisation, I wonder if the issue here is regards to what the default behaviour is. Presently, the default behaviour is to skip over records that cannot be deserialised, having warned the observer via a warning level log output.

Should we change the default behaviour to have the deserialisation panic and rely on the process supervisor to act i.e. treat this situation as unrecoverable?

from akka-edge-rs.

Should we change the default behaviour to have the deserialisation panic and rely on the process supervisor to act i.e. treat this situation as unrecoverable?

That is correct. Would it be possible for the user to override the behavior per event type so that the user can make an explicit decision to skip certain events?

from akka-edge-rs.

Would it be possible for the user to override the behavior per event type so that the user can make an explicit decision to skip certain events?

Sure, but if they want to skip certain events then they could also completely override the way serde deserialises. This would achieve the same outcome, no? By way of example:

#[derive(Deserialize)]
pub struct {
    my_bool: bool,
}

If my_bool was just added, serde will not deserialise and assume false. To override, the programmer would have to (I may have the syntax wrong):

#[derive(Deserialize)]
pub struct {
    #[serde(default)]
    my_bool: bool,
}

Furthermore, you can fully implement Deserialize instead of the macro, which is how you'd handle more complex cases.

from akka-edge-rs.

sounds good

from akka-edge-rs.