Healthcheck without docker about heroku-deploy HOT 5 CLOSED

I'll update the Action to check for status 200.

from heroku-deploy.

Hey sorry it took a while but I've updated the action to check for status code 200 during healthchecks. Hopefully that solves your issue. Closing issue now

from heroku-deploy.

Hey @SpencerKaiser sorry for the late reply. As it stands right now, the healthcheck just checks if the page returns something (even if that something is some html with error info in it as is your case) which is why I think the healthcheck is passing.

So it doesn't quite work as expected and I'm working on fixing that, but in the meantime can you switch to using the checkstring as well. Essentially return some kind of status like working at your healthcheck url and use the checkstring to verify it. Have a look at the documentation for more info

from heroku-deploy.

@AkhileshNS thanks for the response and the clarification! So it doesn't check to see if a 200 is returned? In the example above, the request should have returned a 503 Service Unavailable, so that's why I was surprised it continued. I also didn't see any confirmation that it was actually hitting that endpoint... did I miss something or is that not logged?

I'll definitely go add the checkstring to our pipeline 👌

from heroku-deploy.

Thanks @AkhileshNS !!!

from heroku-deploy.