Code Monkey home page Code Monkey logo

Comments (3)

cwberardi avatar cwberardi commented on May 30, 2024 1

This issue should be addressed in FramesExtractor as well. Given the Windows instructions for ffmpeg save the file in the "Program Files" dir, the below fails because of the space in the directory name. However, it is fixed in the same simple way @CaileanMParker recommended.

Recommended change below:

    def extract(self):
        """
        Extract the frames at every n seconds where n is the
        integer set to self.interval.
        """
        ffmpeg_path = self.ffmpeg_path
        video_path = self.video_path
        output_dir = self.output_dir
        if os.name == "posix":
            ffmpeg_path = shlex.quote(self.ffmpeg_path)
            video_path = shlex.quote(self.video_path)
            output_dir = shlex.quote(self.output_dir)

        command = (
            f'"{ffmpeg_path}"'
            + " -i "
            + '"'
            + video_path
            + '"'
            + " -s 144x144 "
            + " -r "
            + str(self.interval)
            + " "
            + '"'
            + output_dir
            + "video_frame_%07d.jpeg"
            + '"'
        )

        process = Popen(command, shell=True, stdout=PIPE, stderr=PIPE)

Hope this helps and echo the comments on a great package!!

from videohash.

akamhy avatar akamhy commented on May 30, 2024

Just for future reference, I thought that I fixed the issue by copying all files to the temporary storage directory but I forgot that the package now finds the FFmpeg and the installation path can also contain whitespace. Thanks, @cwberardi for using the package on windows and reporting the issue. Also, RIP Python 3.5 support(doesn't matter cuz retired).

from videohash.

akamhy avatar akamhy commented on May 30, 2024

fixed in b8af26a

from videohash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.