Code Monkey home page Code Monkey logo

Comments (6)

ajslater avatar ajslater commented on September 28, 2024 2

Thanks for bringing these up. I hadn't heard of alphanumeric issue suffixes until recently.

The short term fix on the next release will be issues as decimals with one point of precision.

For a larger fix, similar to your suggestion, I might just zero pad these strings on the left so the alpha suffix can be included in the sort. I don't do any arithmetic on issue numbers, so now I'm thinking coercion of the issue field into a numerical type was entirely misguided.

from codex.

ajslater avatar ajslater commented on September 28, 2024

Thanks for reporting this. This was a weird judgement call by me. I do store issue numbers in the database as decimals, but I always thought that actual decimal issue numbers were so rare as to only include half issues.
What your case means is that I will probably just delete the display filter that translates the decimal into fraction characters and display normal decimals.

from codex.

ToxicFrog avatar ToxicFrog commented on September 28, 2024

Yeah, in addition to half-issues I have a lot of fraction-of-ten issues like .1, .2, and .6, and at least one series that has issues 8, 8.50, 8.51, 8.52, 8.53, and 8.54.

from codex.

beville avatar beville commented on September 28, 2024

Marvel is pretty bad with these weird issue number suffixes.

To complicate things even more are issues like these:

Earth X #½
Avengers #001½

And these:

The Amazing Spider-Man #78.BEY
The Amazing Spider-Man #53.LR

And even these with no decimal point:

Wolverine & the X-Men #27AU
Fantastic Four #5AU

One approach is to store the issues as both floats and as original strings, and use the numeric column for sorting queries, and the string column for presentation.

from codex.

ajslater avatar ajslater commented on September 28, 2024

Codex v0.9.14 replaces ½ glyphs in issues with decimals and should display decimal issues to two places.

I'm leaving this issue open as a 🔜 version of codex will change the the type of the issue in the database to a string to support the examples given by beville.

from codex.

ajslater avatar ajslater commented on September 28, 2024

Codev v0.10.1 supports alphanumeric issues and handles alphanumeric issue suffixes fairly well.

Reopen if issues persist.

from codex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.