Code Monkey home page Code Monkey logo

Comments (8)

bytestream avatar bytestream commented on July 20, 2024 1

Thanks very much! I'll let you know if I notice anything.

Merry Christmas to you too! 🎅

from typeface-inter.

ajmalafif avatar ajmalafif commented on July 20, 2024

hi @bytestream,

Thanks for the question and bring this to my attention as I wasn‘t aware.

I‘ll share you context first before answering your question. Having Inter on Google Font has been a long wait dated back in March 2018 (so that we can use them with Kyle‘s typefaces package): google/fonts#1455 (comment)

However I needed them for my projects so I decided to manually host them. We had a convo on Twitter which when the time comes (Inter available on Google Font), Kyle can just override the NPM package and make it work with his typefaces package: https://twitter.com/GatsbyJS/status/1093411095551692800

Also thanks for the fontsource recommendation.

from typeface-inter.

bytestream avatar bytestream commented on July 20, 2024

Thanks for the reply, context and your work on this package @ajmalafif

Personally I don't think Kyle should be publishing v1's on this package name. I'll justify why:

Given the last point, for me, this package still has a use case.

Perhaps @KyleAMathews can weight in. It would be preferable if those versions were removed and published under a different package name. NPM should be able to show you were anyone is actually pulling those v1's. Or at the very least, the README updated to note that there are two independent GitHub repositories publishing under separate version numbers simultaneously.

from typeface-inter.

ajmalafif avatar ajmalafif commented on July 20, 2024

Hi @bytestream,

It took me awhile but I understand what‘s the issue is now and I am tempted to actually overwrite the NPM package to reflect this package. However I will probably mess things up as I am more of a designer than a programmer so I am worried of breaking stuffs unintentionally.

Do you mind doing a PR (like should I have a release tag for this package?) and more than happy to push the changes to NPM.

from typeface-inter.

bytestream avatar bytestream commented on July 20, 2024

I'm not familiar with NPM. I don't think there's anything I can do from GitHub.

To remove the versions I think you need to do one of the below:

  • npm unpublish <package_name>@<version>
  • npm deprecate <package>@<version> "<message>"

See https://www.npmjs.com/policies/unpublish

To update the README / linked repository, it looks like you need to publish a new version:

https://docs.npmjs.com/about-package-readme-files

from typeface-inter.

ajmalafif avatar ajmalafif commented on July 20, 2024

Thanks for these insights!

As you probably could tell I am not really familiar myself other than trying to figure out for my own use case. Give me a couple of days to make sure I don‘t break things and will update the package accordingly.

from typeface-inter.

bytestream avatar bytestream commented on July 20, 2024

No worries, take your time :) I just wanted to make you aware and find out why both versions exist

from typeface-inter.

ajmalafif avatar ajmalafif commented on July 20, 2024

Hi @bytestream,

I‘ve finally found the courage and reverted the npm package back to as per Inter‘s version 3.15 and since I can‘t republish the same version, I‘ve updated it to version 3.15.1 instead: https://www.npmjs.com/package/typeface-inter

Feel free to correct if I‘ve done any mistake with the package, more than happy to fix it.

Oh and Merry Christmas & happy holidays!

from typeface-inter.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.