Code Monkey home page Code Monkey logo

Comments (7)

ajalt avatar ajalt commented on May 25, 2024

I'm not clear on your request. Can you provide more details on what you want?

from reprint.

peterbetos avatar peterbetos commented on May 25, 2024

I meant USE_FINGERPRINT permission was already deprecated starting on Android Pie. Can we also have the library USE_BIOMETRIC as well for Android Pie compatibility?

from reprint.

kenshin171 avatar kenshin171 commented on May 25, 2024

Technically, reprint 3.3.1 can also be used on android Pie, the question should be to swap out FingerprintCompatManager api to BiometricPrompt api from the androidx BiometricPrompt library from Google. This library should provide support for android devices which utilises any form of biometric authentication not only fingerprint.

However it is currently in alpha, alpha-03 to be exact, as shown here https://developer.android.com/jetpack/androidx/releases/biometrics#1.0.0-alpha03 and here in maven https://mvnrepository.com/artifact/androidx.biometric/biometric/.

Perhaps a branch in preparation for use of this new biometricprompt library?

This library also is aa appCompat library as it supports api level 14 onwards.

from reprint.

ajalt avatar ajalt commented on May 25, 2024

This library doesn't use FingerprintManagerCompat any more, due to bugs in it's implementation. So I probably won't use the androidx library either. I don't see a reason not to add the USE_BIOMETRIC in addition to USE_FINGERPRINT, however.

from reprint.

kenshin171 avatar kenshin171 commented on May 25, 2024

Ah my apologies I meant FingerprintManager not FingerprintManagerCompat. As stated in https://developer.android.com/reference/android/hardware/fingerprint/FingerprintManager it's deprecated in API 28 in favour of androidx biometricPrompt api

from reprint.

benwicks avatar benwicks commented on May 25, 2024

I started a PR with this change but I closed it because it would require devices with Pie to use a hacky workaround to determine if a fingerprint is registered. This may cause even more compatibility issues. I'll keep the branch around if anyone wants to look into it more.

from reprint.

ajalt avatar ajalt commented on May 25, 2024

Echoing @benwicks comment, it looks like using BiometricPrompt has no advantages currently (since it just forwards calls to FingerprintManager), and does have some drawbacks (the workaround). So I'm going to keep using FingerprintManager for now, but we can revisit this when future versions of Android come out.

Thanks again to @benwicks for working on this!

from reprint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.