Crash when using MDC Compose Theme Adapter about showkase HOT 6 CLOSED

I can only assume that it has to do with the Context-manipulation used for the different preview-flavors has something to do with it.

This assumption appears to have been correct - the offending context is from RTLComponentCard. This appears, in turn, to be caused by Context::createConfigurationContext not inheriting the theme of its parent context, and hence upon resolution receiving the default theme for the platform (for API 29, where I'm performing these tests, this is android:style/Theme.DeviceDefault.Light.DarkActionBar).

I realize that working around this limitation might be out of scope for this library, but I think it might be possible to work around the issue by 'forwarding' the theme of the parent context to the newly created context by Context::createConfigurationContext. If time allows, I'll make a PR!

from showkase.

Come to think of it - what is the reason that a configuration-context is created in this case? 🤔

Looking at the code, the following line:

Could the configuration-context be redundant in this case?

from showkase.

@hedvigoscar I think you might be right. Afair, LocalLayoutDirection didn't exist when I first created Showkase. I probably added it during some of the later iterations. I think you might be right about it being fine to remove it. Do you wanna push that PR since you found the issue anyway :D I can do it too but would love to make sure you get credited with a contribution to your name!!

from showkase.

That's thoughtful of you, thanks!

I'll have it up shortly.

from showkase.

Done, check out #168 @vinaygaba 🙂

from showkase.

Fixed by #168

from showkase.