--ignore-buttons does not work with remapped buttons about unclutter-xfixes HOT 3 OPEN

Thanks! I think we need to look into what xinput does under the good, and find out if we can query this mapping through some API in Xinput2. If so there shouldn't be any reason why we can't respect the mapping.

from unclutter-xfixes.

Relevant code from xinput: https://cgit.freedesktop.org/xorg/app/xinput/tree/src/buttonmap.c

The button map is actually device specific. We can use XGetDeviceButtonMapping to get the map, and I think the raw event has a deviceid property.

Edit: Also, just for reference, here's the XI2 spec: https://www.x.org/releases/X11R7.7/doc/inputproto/XI2proto.txt

from unclutter-xfixes.

Approach-wise, we can do the following:

static bool is_button_ignored(const XIRawEvent *data) {
    if (config.ignore_scrolling && (data->detail == 4 || data->detail == 5)) {
        return true;
    }

    if (config.ignore_buttons.count == 0) {
        // Return early so we don't query the mapping unless needed
        return false;
    }

    long mapped_button = /* … Get mapping of data->detail … */
    // …
}

I think for --ignore-scrolling we should not map the 4 / 5 as I believe those should always be interpreted as scroll wheel – I'm not entirely sure, to be honest, though. Even if so, the user could always ignore scrolling respecting the mapping by using --ignore-buttons instead then.

from unclutter-xfixes.