Code Monkey home page Code Monkey logo

Comments (6)

AlexanderMartynoff avatar AlexanderMartynoff commented on June 30, 2024 2

Ok. What if I want to check for multiple privileges? For example:

@has_permission([Permission.WRITE, Permission.DELETE], context)
def do(request):
    ...

Or maybe even more complex needs - not a set of privileges, but a predicate (which can have any type). Because it may be necessary to combine privileges with AND or OR.

from aiohttp-security.

asvetlov avatar asvetlov commented on June 30, 2024

Please describe your case

from aiohttp-security.

asvetlov avatar asvetlov commented on June 30, 2024

It is another problem.
Passing predicate to query unknown storage looks weird. Also, it overcomplicates code reading and debugging.

Django checks for single permission only: https://docs.djangoproject.com/en/2.0/topics/auth/default/#default-permissions
Pyramid does the same: https://docs.pylonsproject.org/projects/pyramid/en/latest/api/request.html#pyramid.request.Request.has_permission

Why aiohttp-security should overcomplicate its API?

from aiohttp-security.

AlexanderMartynoff avatar AlexanderMartynoff commented on June 30, 2024

It will not be necessary to complicate the API - only removing the restriction on the type of permissions.

Under the predicate, I meant something like this:

@has_permission (WRITE || READ, context)
def do (request):
     ...

or

@has_permission (WRITE & DELETE, context)
def do (request):
     ...

Where:

READ, WRITE, DELETE - instances of some type (for example, Predicate), combinations using the &, || they are also predicates.

This is what I would like to do in my project, and I'm stopped only by the restriction on the type of the first argument to the has_permission function.

from aiohttp-security.

asvetlov avatar asvetlov commented on June 30, 2024

WRITE ^ DELETE? I feel it makes a mess.

from aiohttp-security.

AlexanderMartynoff avatar AlexanderMartynoff commented on June 30, 2024

Sorry for long time answer. I will not argue. But I wanted to know what the mess you mean?

from aiohttp-security.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.