method '*' treated differently from others about aiohttp-cors HOT 9 OPEN

@wumpus sorry.
Please ping me in, say, 10 days.
Ok?
I have no free time to work on the issue personally now (review only maybe) but really want to get CORS plugin working.
Last months worked hard on CPython, added several important changes to asyncio. Have to finish this job before returning back to aio-libs projects.

from aiohttp-cors.

If you provide a patch I'm happy to review it.

from aiohttp-cors.

I suspect it's a bug that aiohttp-cors works great for GET and throws a configuration error for method '*'.

I don't see any tests for method '*' actually working. There are tests in tests/unit/test_cors_config related to webviews and mixins. That appears to be the only tests related to method '*'.

aiohttp-graphl is an example of middleware that expects method='*' to work

from aiohttp-cors.

Ping.

I think the basic issue is:

• CORS preflight request is a OPTIONS
• Lazy coders create routes to method='*' in middleware like aiohttp-graphl
• aiohttp-cors treats method='*' specially because it includes OPTIONS
• it would be nice if the middleware still worked

from aiohttp-cors.

Hi, @asvetlov !
I encountered the same error. Are there any solutions?

from aiohttp-cors.

Same problem here

from aiohttp-cors.

@andrii-maksymov and @jogc what middleware are you using?

from aiohttp-cors.

this is what i do, there is no other middleware used

aiohttp_jinja2.setup(app,
    loader = jinja2.FileSystemLoader(os.path.dirname(os.path.abspath(__file__)) + '/templates'),
    extensions = [ 'pypugjs.ext.jinja.PyPugJSExtension' ])

aiohttp_graphql.GraphQLView.attach(app, schema = schema,
    graphiql = True)

cors = aiohttp_cors.setup(app, defaults={
    'http://127.0.0.1:3000': aiohttp_cors.ResourceOptions(
        allow_credentials=True,
        expose_headers='*',
        allow_headers=('Content-Type',),
    )
})

from aiohttp-cors.

Thanks @jogc so you're using exactly the same middleware that I am.

Here is my patch that works around the problem in aiohttp_graphql, by handling every method other than OPTIONS:

graphql-python/aiohttp-graphql@master...wumpus:master

from aiohttp-cors.