Code Monkey home page Code Monkey logo

Comments (10)

Dreamsorcerer avatar Dreamsorcerer commented on May 24, 2024

I'd suggest pushing 1 more release that included a deprecation warning on import though. To help ensure that all users are aware of the change.

from aioredis-py.

Andrew-Chen-Wang avatar Andrew-Chen-Wang commented on May 24, 2024

from aioredis-py.

Dreamsorcerer avatar Dreamsorcerer commented on May 24, 2024

#1413

from aioredis-py.

Dreamsorcerer avatar Dreamsorcerer commented on May 24, 2024

I suggested we could maybe revert the 2.0 change back to 1.3.1 and bump it to version 3, but that might be confusing.

I'm not familiar with the 2.0 change, but, would that cause problems for users who are already using v2? Could always push 2 deprecation updates, a 2.0.2 and a 1.3.2 release.

from aioredis-py.

Andrew-Chen-Wang avatar Andrew-Chen-Wang commented on May 24, 2024

2.0 change was for the redis-py port, but that is now in the redis-py package itself. I think a deprecation notice for both major version is a good idea.

I'm htinking 3.0 will be the exact same as 1.3.1 (where the original maintainer last left it), then we can push a 3.1.0 change with the additional changes seandsteward and I merged later on.

from aioredis-py.

Dreamsorcerer avatar Dreamsorcerer commented on May 24, 2024

I'm htinking 3.0 will be the exact same as 1.3.1 (where the original maintainer last left it), then we can push a 3.1.0 change with the additional changes seandsteward and I merged later on.

Wouldn't that mean people who already upgraded to v2 will have problems with v3? I'm not really sure why a v3 is needed.

from aioredis-py.

Andrew-Chen-Wang avatar Andrew-Chen-Wang commented on May 24, 2024

For those who used v2, they should be migrating to redis-py now, as mentioned in the README today.

For v3, it would be the original aioredis.

from aioredis-py.

Dreamsorcerer avatar Dreamsorcerer commented on May 24, 2024

If they've not migrated to v2, then they can just stay on v1 for now (likely they have it pinned as <2). Whenever they decide to update to a new major release, they should move to redis-py. I still think a v3 is likely to cause issues.

from aioredis-py.

seandstewart avatar seandstewart commented on May 24, 2024

I think at this point, we can simply leave a note on the readme pointing folks to redis-py and archive this repository and the PyPI package.

@Andrew-Chen-Wang - if you're happy with that, I'll move forward with it. If you'll manage updating the repo, bumping a patch version, and publishing to PyPI, then I'll manage archiving the package on PyPI once it's done. Maybe add an import-time DeprecationWarning to boot.

from aioredis-py.

Dreamsorcerer avatar Dreamsorcerer commented on May 24, 2024

I think a 1.x Deprecation is probably irrelevant anyway. Anyone on 1.x should already know they need to upgrade to 2.x, and will discover the project is archived at that time. A 2.x DeprecationWarning would still be nice (I've just found aioredis still being used in my new job), but I'll leave it to you guys to decide what to do.

from aioredis-py.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.