Comments (4)
ain
commented on May 20, 2024
1
Landed in v1.6.0.
from smartbanner.js.
ain
commented on May 20, 2024
Hi @aspmaker, thank you for your interest.
Currently not. At the moment smartbanner.js cookie behaviour mocks the original Apple Smart App banner behaviour by creating a cookie as per browser session.
Nevertheless, I can't see any arguments against such feature and I can see your use-case. I'd gladly accept your Pull Request with this feature.
Before you start, please see contribution guidelines and make sure you add tests against your feature.
from smartbanner.js.
igor10k
commented on May 20, 2024
@ain Apple docs state that banner won't reappear, so cookie per session doesn't mock the original behavior.
When the user returns to the webpage, the banner won’t reappear.
from smartbanner.js.
ain
commented on May 20, 2024
@igor10k you're probably right. Nevertheless, it's not a good idea to change this behaviour due to legacy reasons, but I'd be more than glad to merge a reasonable PR on this.
from smartbanner.js.
Related Issues (20)
- Hide smart app banner in web app HOT 4
- Smartbanner for Huawei without Play Store HOT 1
- Smart Banner ios version displayed for touch screen enabled desktops HOT 1
- Angular 2+ compatibility HOT 1
- How to hide smartapp banner in webview apps HOT 1
- Why app banner is displaying in laptop screens, 1440 X 734 / 1366 X 768? HOT 8
- Is there a way to add two smart banners? HOT 1
- support for another language in content ? HOT 3
- min file no correctly exported? HOT 2
- Does it work in Angular? For me it is not showing HOT 1
- Unexpected token ')' when close banner HOT 1
- Invisible App Icon HOT 3
- Will view button be changed to open button if app is already installed in mobile(android or iOS ? HOT 1
- Windows Convertibles are recognized as iOS devices HOT 5
- Accessibility concern with tabbing to banner HOT 5
- smartbanner is visible on windows tab when enabled-platforms is set to android,ios HOT 3
- Error library when I use install with npm HOT 14
- Required content HOT 6
- Js and CSS files are throwing error HOT 5
- Value for enabled-platforms HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smartbanner.js.