Code Monkey home page Code Monkey logo

Comments (7)

matass avatar matass commented on June 1, 2024 2

Hi, Ain. there`s an issue with close button.
screen shot 2017-01-31 at 2 59 40 pm

Also I have one more question.
How could I disable this plugin? If my page does not have meta tag?
error mesaage:
screen shot 2017-01-31 at 3 03 30 pm

from smartbanner.js.

ain avatar ain commented on June 1, 2024 1

Thanks to @fkoester, fix landed in 1.4.1.

from smartbanner.js.

ain avatar ain commented on June 1, 2024

I've just tested on iOS Firefox 5.3 (2) and it worked as expected.

You can compare your implementation to dist/index.html and see if you can reproduce the problem there as well. If you can, it is a component problem so I'd kindly ask you to provide more details about your platform. If not, it's an implementation problem.

As for implementation advice, look into your (S)CSS for any rules that might cause the malfunction.

from smartbanner.js.

ain avatar ain commented on June 1, 2024

@matassim smartbanner.js initialises automatically whenever JavaScript is included on page. Just make sure that you don't include JavaScript if you don't have meta tags on page.

Tools like Webpack will allow you to appropriately bundle as per page/layout.

from smartbanner.js.

matass avatar matass commented on June 1, 2024

thanks for fast reply. we are using your plugin in rails app. Script is automatically loaded from vendor. In some cases we don't want to show smartbanner. Anyway, thank`s for the plugin, we'll try to find out the solution and I will let you know

from smartbanner.js.

ain avatar ain commented on June 1, 2024

@matassim I see. You can go for a conventional change by always keeping the meta tags and apply Advanced usage for UA-based filtering in scenarios you don't need the smartbanner.js to show up.

from smartbanner.js.

fkoester avatar fkoester commented on June 1, 2024

Had the same problem, fixed using patch from PR #32

from smartbanner.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.