Code Monkey home page Code Monkey logo

Comments (6)

ai avatar ai commented on July 24, 2024

After investigation I have figured out that whole node-fetch package was replace with some small esbuild global.fetch polyfill

It is expected behavior. Why it doesn’t work for you?

from size-limit.

slavik-chapelskyi avatar slavik-chapelskyi commented on July 24, 2024

After investigation I have figured out that whole node-fetch package was replace with some small esbuild global.fetch polyfill

It is expected behavior. Why it doesn’t work for you?

Because the package I'm checking bundle size is developed to be used in node projects only, and I'm interested in what the actual bundle size for node project not supporting fetch

from size-limit.

ai avatar ai commented on July 24, 2024

In my world, there is no such thing as bundle size for Node.js project since you do not need bundlers for Node.js.

What do you mean for “bundle” in Node.js and why do you care about it’s size?

from size-limit.

slavik-chapelskyi avatar slavik-chapelskyi commented on July 24, 2024

Our backend is build on top of AWS lambda, which have size limit of 50mb.
So there is cold start problem when it comes to lamdas https://khalilstemmler.com/blogs/serverless/5-ways-to-manage-lambda-cold-starts/#Understanding-the-Cold-Start-Problem
While bundle size is not primary first problem with cold starts, we are still care about reusable packages bundle size to make it each lambda as small as possible, to ensure smaller cold starts

from size-limit.

slavik-chapelskyi avatar slavik-chapelskyi commented on July 24, 2024

I was able to fix this by replacing size-limit-preset-node-lib with undocumented modifyEsbuildConfig option and setting esbuild platform to node.

CleanShot 2022-12-13 at 18 54 26@2x

from size-limit.

ai avatar ai commented on July 24, 2024

Interesting problem :-/

Seems like you need to set custom esbuild config with a target to Node.js https://esbuild.github.io/api/#target

It will disable auto-polyfills.

Try to use config option in Size Limi config.

from size-limit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.