Size-limit exits with non-zero if sizes are equal to reported about size-limit HOT 10 CLOSED

I like the idea to show the difference! :)

from size-limit.

Seems like we need to show bytes here to explain reason.

from size-limit.

But this issue will be low priority since we recommend to add extra bytes for limits. In you case, most of PR will fall build step. Even if you add one single variable.

from size-limit.

Makes sense but still very confusing for the first experience. Probably some error boundaries should be backed into the library?

from size-limit.

Can’t reproduce :(. Can you share your project?

from size-limit.

Been trying it here: react-dropzone/attr-accept#11 and ended up increasing the limit.

from size-limit.

Done c6e45a3

from size-limit.

I will release it with messages fixes.

from size-limit.

Thanks!

I'm still a bit concerned about the DX here. Now it reports size in bytes, but we specify it in KBs or even MBs which will lead to an additional mental overhead for developers. I see at least two ways how this can be improved:

1. Do not show the actual size, instead show the difference.
2. Additionally display pretty formatted sizes

Something like:

Limit exceeded by 142 Bytes!
Actual size: 1.6 KB - 16343 B
Size Limit: 1.6 KB - 15634 B

Or a table view probably?

Actual | Limit  | Diff
-------------------------
1.6 KB | 1.6 KB | +12 B

from size-limit.

Done 6d1cc85

from size-limit.