Code Monkey home page Code Monkey logo

Comments (8)

swernerx avatar swernerx commented on July 24, 2024

That's the exception thrown right now:

> size-limit
 ERROR  Error: 
ERROR in ./lib/Core-DnMX9gqv.css
Module parse failed: /Users/Sebastian/Workspace/sebastian-software/edge-core/lib/Core-DnMX9gqv.css Unexpected token (14:0)
You may need an appropriate loader to handle this file type.
|  */
| 
| ::before,
|  ::after {
|    background-repeat: no-repeat; /* 1 */
 @ ./lib/browser.es5.esm.js 13:0-44
 @ multi ./lib/browser.es5.esm.js
    at runWebpack.then.stats (/Users/Sebastian/Workspace/sebastian-software/edge-core/node_modules/size-limit/index.js:110:15)
    at <anonymous>

from size-limit.

ai avatar ai commented on July 24, 2024

Why we should not bundle them? They affects to bundle size and developers should take care.

Totally agree that it should not throw error. Let's add config for css-loader. Do you want to make PR?

from size-limit.

swernerx avatar swernerx commented on July 24, 2024

Both is okay in my opinion. If size-limit is mainly about JS size then it should respect JS only.

I mean right now you basically exclude asset files as well, as file-loader is replacing them with URLs.

I am not sure what is the right approach here.

If you like to have CSS included in the bundle, I'll do that PR.

from size-limit.

ai avatar ai commented on July 24, 2024

Are you sure, that file-loader replaces then to URL? I thought url-loader does it.

from size-limit.

swernerx avatar swernerx commented on July 24, 2024

It's the other way around.

"The url-loader works like the file-loader, but can return a DataURL if the file is smaller than a byte limit." via https://github.com/webpack-contrib/url-loader

from size-limit.

swernerx avatar swernerx commented on July 24, 2024

I am not sure about assets being added to the size. Sometimes you e.g. offer alternative file formats e.g. woff and woff2. I figure most people would never inline all of them.

from size-limit.

swernerx avatar swernerx commented on July 24, 2024

Here we go: #15

from size-limit.

ai avatar ai commented on July 24, 2024

Released in 0.10

from size-limit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.