Code Monkey home page Code Monkey logo

Comments (7)

peterhorne avatar peterhorne commented on September 27, 2024

A possible work around is to rename cr-player.html to cr-player.html.erb and use the asset_path helper:

<link rel="stylesheet" href="<%= asset_path('cr-player/cr-player.css') %>">

However, that prevents the stylesheet from being inlined which defaults the whole point of using Emcee in the first place!

from emcee.

ahuth avatar ahuth commented on September 27, 2024

Right now the gem doesn't support this, although there has been some discussion about it.

Until now I haven't thought too much about it. I do think the gem should support it, so I'll start looking at processing stylesheets and scripts before inlining them. Also, if you have any thoughts about implementation, I'm definitely willing to entertain ideas/pull-requests.

from emcee.

ahuth avatar ahuth commented on September 27, 2024

Also, I forgot to mention: you're using this exactly right, so no apologies necessary. And thank you for making a repo demonstrating the issue. That makes this a lot easier to tackle.

from emcee.

peterhorne avatar peterhorne commented on September 27, 2024

Okay, thanks! I'll be sure to let you know if I have any ideas.

from emcee.

ahuth avatar ahuth commented on September 27, 2024

@peterhorne The last couple of days I've been working on this, and the compile-scss branch now works.

The current organization of the StylesheetProcessor doesn't really let me unit test this, which is a problem. It works, but I want to fix that before it gets merged in to a release.

Just wanted to let you know that this has been worked on and it does work.

from emcee.

ahuth avatar ahuth commented on September 27, 2024

@peterhorne I have managed to unit test the sass processing part. The changes have been merged and pushed to a new release. It's also been pushed to rubygems.org, so you should be good to go.

Also, I did verify that your example-repo now works correctly.

Let me know if you have any issues with it, and thanks for raising the issue.

from emcee.

peterhorne avatar peterhorne commented on September 27, 2024

Awesome! Thank you very much!

from emcee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.