Comments (2)
Merging the double annotation into one as <ocaml from="Proto" predef>
works.
Either we should internally merge these, or issue a warning or error when a double annotation is found.
from atd.
A possible location to do an adhoc merge might be in atd/src/annot.ml
, line 12:
let field ~section ~field l =
let open Option.O in
List.assoc section l >>= fun (_, l2) -> List.assoc field l2
Instead of choosing the first matching section and look for a matching field there, we could scan the annotation for all matches for section
an field
in l
and proceed according to the number of matches:
- for zero or one match, behaviour is unchanged
- for two or more matches, options are:
- Choose first match and warn of duplicate fields (allows ambiguous fields)
- Fail with error "duplicate field" (may break stuff)
If this is the right solution and there is a decision on the behaviour, I would give it a try.
That is, if this issue is still relevant :-)
from atd.
Related Issues (20)
- Extracting strings from variants includes the escaped quotes HOT 4
- Way to support adapter.ocaml="Type_field" for the TypeScript backend HOT 3
- atddiff: provide output without line/column info for more stable results
- atddiff: Print the git file path instead of temporary paths when using `git difftool`
- atddiff: don't print error message with --version
- atddiff (and other tools): show snippets of code when reporting errors
- Documentation at https://atd.readthedocs.io/ no longer updates HOT 2
- atdd: generate .di files
- atdgen: menhir error HOT 5
- atdd: support recursive declaration through references
- atdd: workaround dlang compiler bug with SumTypes
- atdgen: mixing ATD with raw Yojson.Basic.t objects HOT 2
- atdpy: `to_json` and `from_json` incorrect for aliases of `unit`
- atdgen: allow empty records
- atdgen: `int <ocaml repr="int64">` uses JSON strings instead of JSON numbers HOT 1
- Is there a way to use atdgen in a dune project? HOT 1
- atdgen: strange generated JSON for sum type HOT 5
- atdcat: what is the <root type name> of the -jsonschema option for? HOT 1
- Add a ReScript output option HOT 1
- Retire support for nonstandard JSON syntax in atdgen 3.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from atd.