Code Monkey home page Code Monkey logo

Comments (2)

mjambon avatar mjambon commented on September 15, 2024

Merging the double annotation into one as <ocaml from="Proto" predef> works.

Either we should internally merge these, or issue a warning or error when a double annotation is found.

from atd.

syntakker avatar syntakker commented on September 15, 2024

A possible location to do an adhoc merge might be in atd/src/annot.ml, line 12:

let field ~section ~field l =
  let open Option.O in
  List.assoc section l >>= fun (_, l2) -> List.assoc field l2

Instead of choosing the first matching section and look for a matching field there, we could scan the annotation for all matches for section an field in l and proceed according to the number of matches:

  • for zero or one match, behaviour is unchanged
  • for two or more matches, options are:
    1. Choose first match and warn of duplicate fields (allows ambiguous fields)
    2. Fail with error "duplicate field" (may break stuff)

If this is the right solution and there is a decision on the behaviour, I would give it a try.

That is, if this issue is still relevant :-)

from atd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.