Comments (6)
Nope, that is definitely a bug, I will try to reproduce and fix. Thanks for flagging.
from storybook-mobile.
You're right that the code checks for overflow-x
and overflow-y
in addition to just overflow
.
Is that what you mean-- that ideally you'd want to see those attributes listed as well? Or maybe I'm misunderstanding, and there is a bug and the rule is applying to containers it shouldn't be?
from storybook-mobile.
I guess I’m just wondering if it applies that rule if it recognizes overflow it’s any value. Write now I have overflow: hidden in my code and it’s still suggesting that I use touch. Is that correct?
from storybook-mobile.
Hey @aholachek - is there any update on a fix for this bug? I’d love to get this integrated into our orgs repos but I don’t want to do so until the false positives defined in this PR are fixed.
from storybook-mobile.
Hi @CodeByAlex, after some back and forth with having trouble reproducing this, I decided to remove the rule since it only affects iOS 12 and below (which is something like <2-3% of mobile users at the moment according to "netmarketshare.com", not sure how reliable that is).
from storybook-mobile.
The most recent release is the one that removed the rule: https://github.com/aholachek/storybook-mobile/releases/tag/v0.1.22
from storybook-mobile.
Related Issues (12)
- After including this addon receiving error while running storybook HOT 12
- Error after including the addon
- Warning: Each child in a list should have a unique "key" prop. HOT 7
- very poor performance on large storybook codebase HOT 16
- Thank you! HOT 1
- Adding this addon to a react library results in a hooks error in a consuming react app HOT 3
- More issues shown next to tab than there actually are HOT 2
- [BUG]: Deprecated emotion-theming imports HOT 3
- Check only the canvas elements? HOT 1
- Upgrade to Storybook 6.5 + React 18 HOT 2
- Message "button with content Set string" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from storybook-mobile.