Code Monkey home page Code Monkey logo

Comments (6)

aholachek avatar aholachek commented on May 22, 2024 1

Nope, that is definitely a bug, I will try to reproduce and fix. Thanks for flagging.

from storybook-mobile.

aholachek avatar aholachek commented on May 22, 2024

You're right that the code checks for overflow-x and overflow-y in addition to just overflow.

Is that what you mean-- that ideally you'd want to see those attributes listed as well? Or maybe I'm misunderstanding, and there is a bug and the rule is applying to containers it shouldn't be?

from storybook-mobile.

CodeByAlex avatar CodeByAlex commented on May 22, 2024

I guess I’m just wondering if it applies that rule if it recognizes overflow it’s any value. Write now I have overflow: hidden in my code and it’s still suggesting that I use touch. Is that correct?

from storybook-mobile.

CodeByAlex avatar CodeByAlex commented on May 22, 2024

Hey @aholachek - is there any update on a fix for this bug? I’d love to get this integrated into our orgs repos but I don’t want to do so until the false positives defined in this PR are fixed.

from storybook-mobile.

aholachek avatar aholachek commented on May 22, 2024

Hi @CodeByAlex, after some back and forth with having trouble reproducing this, I decided to remove the rule since it only affects iOS 12 and below (which is something like <2-3% of mobile users at the moment according to "netmarketshare.com", not sure how reliable that is).

from storybook-mobile.

aholachek avatar aholachek commented on May 22, 2024

The most recent release is the one that removed the rule: https://github.com/aholachek/storybook-mobile/releases/tag/v0.1.22

from storybook-mobile.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.