Comments (8)
You're right looks like my scroll disable script doesn't support touch devices @generatepress .. I'll update and close the issue once I test it!
Thanks for point it out 👍
from sliiide.
Awesome, thanks!
from sliiide.
Ok It's updated and tested on nexus 5 and iphone 6 .. the scroll flag should be working on mobile now. You can test it out here
I'm gonna close this issue for now but just let me know if you run into any related issues or open a new one if it's unrelated 😄 @generatepress
from sliiide.
Looks like it's working - thanks! :)
However, my slide out content is longer than the initial viewport on mobile, so I had to add overflow: auto to it.
This update made it so I can't scroll within my slide out content on mobile either - seems to have disabled mobile scrolling altogether instead of just within the body content.
from sliiide.
Yeah the listener that prevents scroll is attached to the body so it applies to all elements. Can you send me a fiddle or a live page that you're working with? I have an idea I can try out as a quick fix. the plugin wasn't really designed for large pieces of content that's why I never considered that case but I could potentially have a quick fix for it @generatepress
from sliiide.
Maybe this will help: http://codepen.io/anon/pen/rOqyNd
Basically it would be great if we were able to scroll inside the slideout element. Some mobile phones don't have a lot of visible room, so scrolling can be necessary to see all links or content.
Thanks! :)
from sliiide.
Ok I see, the disable scroll function is pure javascript so it attaches to window. Try dropping my no_scroll functionality and using this instead https://github.com/ultrapasty/jquery-disablescroll
I'll try porting over my code to jQuery that will probably help with but I think it'll take time for me to do it and test it on a bunch of browsers so in the mean time give that plugin above a shot, I think it can solve your problem @generatepress
from sliiide.
I found the best way to do this is to add a class to the body element when the slider is opened.
Then just add some simple CSS:
.slide-opened {
overflow: hidden;
}
.slideout-content {
overflow-y: auto;
}
from sliiide.
Related Issues (20)
- Menu scroll HOT 3
- package.json
- Stay open HOT 7
- Caching HOT 2
- [Idea] Attach toggle icon to sidebar HOT 1
- Create events (OnSlide, OnSlideFinished) HOT 2
- License info HOT 2
- Close the menu HOT 1
- Double Click to initiate slider HOT 1
- Scroll inside menu
- close navigation
- Slide behind window HOT 1
- preventDefault passive
- shadow should also be able to handle toggle HOT 2
- Toggle image by click or swipe HOT 8
- Windows Phone 8 / IE10 HOT 2
- overflow: scroll; not effecting the menu HOT 1
- effect where the menu appears on the website ? HOT 1
- Html Overflow-X: Hidden Issue HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sliiide.