Code Monkey home page Code Monkey logo

Comments (20)

ahmdrz avatar ahmdrz commented on August 22, 2024

That's right.
We need more test methods.
Coveralls.io result is low.

from goinsta.

ahmdrz avatar ahmdrz commented on August 22, 2024

I'm very busy. Can you write test methods ?

from goinsta.

ghostiam avatar ghostiam commented on August 22, 2024

@ahmdrz After my big commit, I'll take a look.

from goinsta.

ghostiam avatar ghostiam commented on August 22, 2024

I'll start writing tests :)

from goinsta.

ahmdrz avatar ahmdrz commented on August 22, 2024

Thank you

from goinsta.

ghostiam avatar ghostiam commented on August 22, 2024

I wrote a few tests, they started to fall, it's good.
default

from goinsta.

ahmdrz avatar ahmdrz commented on August 22, 2024

Did you test again after changing response structs ?

from goinsta.

ghostiam avatar ghostiam commented on August 22, 2024

Run 3 tests(Travis CI) at the same time, bad, the API gives errors due to frequent requests.

from goinsta.

ghostiam avatar ghostiam commented on August 22, 2024

@ahmdrz
Yes, you do not see that these are different commits, I did it at the same time.
Errors in tests because of frequent requests. Could you restart the test in Travis?

from goinsta.

ghostiam avatar ghostiam commented on August 22, 2024

@ahmdrz
2017-04-15 14 37 51

from goinsta.

ahmdrz avatar ahmdrz commented on August 22, 2024

goinsta_test.go:181: Invalid status code {"message": "User not found", "status": "fail"}

from goinsta.

ghostiam avatar ghostiam commented on August 22, 2024

@ahmdrz in this this test no error "user not found"
https://travis-ci.org/ahmdrz/goinsta/jobs/222286588

from goinsta.

ghostiam avatar ghostiam commented on August 22, 2024

2017-04-15 14 48 49

It seems to me that the instagram gave us erroneous data.

from goinsta.

ahmdrz avatar ahmdrz commented on August 22, 2024

Could you restart the test in Travis?

You have to change user id in line 181...
If I restart travis , we will fail again...

from goinsta.

ahmdrz avatar ahmdrz commented on August 22, 2024

I think it will be good if we search user by username...

from goinsta.

ghostiam avatar ghostiam commented on August 22, 2024

2 identical tests for Travis, and the result is different.

2017-04-15 14 50 41

from goinsta.

ghostiam avatar ghostiam commented on August 22, 2024

@ahmdrz Can you restart the tests separately, not all together?

from goinsta.

ahmdrz avatar ahmdrz commented on August 22, 2024

No I can't because it is not easy...
I will restart travis...

from goinsta.

ghostiam avatar ghostiam commented on August 22, 2024

One test fail

=== RUN TestSetPublicAndUnPublicAccount
--- FAIL: TestSetPublicAndUnPublicAccount (0.06s)
goinsta_test.go:623: Invalid status code {"message": "Please wait a few minutes before you try again.", "status": "fail"}

from goinsta.

ghostiam avatar ghostiam commented on August 22, 2024

Instagram does not change the status of account 6 times...

from goinsta.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.