Create/Delete secrets ui about agola-web HOT 3 CLOSED

@raynasorint

Here the user can insert the secret name and upload the secret value file that will be validate before saving the string and will be shown in the preview Json format container.

I don't understand why there's a json entry in the ui that contains (as from you mockups) the secret api request here. These are internal details that shouldn't appear in a ui.

The secrect create/edit ui should add some fields to set/change:

• secret name
• secret data, just a k/v map of strings that could be represented with a list of text fields for key/value and a check for key uniqueness. Then an option to upload this list could also be added.

The secret type will always be internal since there's currently no other option.

from agola-web.

I don't understand why there's a json entry in the ui that contains (as from you mockups) the secret api request here. These are internal details that shouldn't appear in a ui.

The secrect create/edit ui should add some fields to set/change:

secret name
secret data, just a k/v map of strings that could be represented with a list of text fields for key/value and a check for key uniqueness. Then an option to upload this list could also be added.
The secret type will always be internal since there's currently no other option.

I tried to define better the ui.

Here the initial step with the button Add Secret, and the list of the secrets variable that user can delete.

Here the form after clicking Add Secret:

In this step of creation the user can create the Secret adding one by one a key-value pair.
When the user submit the entire form all key-value pairs and the secret name will be send to the backend as new Secret variable.

The form will contain validation about empty fields, unique secrets name and a secret keys uniqueness.

from agola-web.

@raynasorint

Some suggestions:

• use a new page for secret create/edit (preferred over inline or a modal)
• Don't add delete from All secrets, it doesn't makes sense
• Delete secret modal should ask for "delete secret" not "delete secret value".

Anyway go ahead and implement this. It could also be split in multiple PR to keep a better separation of logical changes.

from agola-web.