Hello guys, do i need to set time zone when using this library? about cron HOT 6 OPEN

@Jayesslee: this is running only on the local clock. What is the requirement with time zone you are looking for?

from cron.

I think it would be useful to allow each schedule to optionally have a non-local timezone.

My use case is to manage different schedules for different users in their preferred timezone, but since the tasks will be scheduled all on one server, the server needs to be able to juggle different timezones. Translating the schedule into the server's timezone won't work since that will change the behaviour of schedules near midnight when transitioning in and out of daylight saving time.

from cron.

I can see that this can get super-complex easily. Do you have any suggestion how to implement this?

from cron.

I had only given a thought to the API design, which would be to add a timezone parameter to schedule() which defaults to local time.

But looking at the code, that timezone could then be propagated to an extra field in _ScheduledTask so that tick() can apply that timezone before passing the applicable DateTime into schedule.shouldRunAt(now).

There are other ways to go about it such as making it a parameter of Schedule instead, but the above seems to be the most flexible.

from cron.

I'm happy to review and merge this (esp. with at least a few test cases), but I don't have time for it right now. Are you interested?

from cron.

I'm not 100% sure on which API design would be best. Of course it's a matter of whether you want to think about a Schedule being something that is in a particular timezone, or being timezone agnostic. While the original cron itself wasn't designed with this consideration, if I take systemd timer units as inspiration, the timezone there IS actually part of the schedule string, so arguably there is some sense in making the timezone an extra field in Schedule even though it was not there in the original cron.

So for now I think I wouldn't jump into anything just yet and see if there's any feedback on the API before committing to it.

from cron.