Access control is not respected about ellipticcurvekeypair HOT 17 CLOSED

Allright. This is now published and available on cocoapods, carthage and on master on this repo! Thanks again.

from ellipticcurvekeypair.

Thank you for using this library and reporting this issue. I'll have a look.

from ellipticcurvekeypair.

Okay, so basically what you are saying is if we don't provide any kSecAttrAccessControl when saving the key it will default to class 6 (kSecAttrAccessibleWhenUnlocked)?

from ellipticcurvekeypair.

from ellipticcurvekeypair.

Allright, we've got two choices then. Either have an opinionated logic where we use the same access control for both private and public key.. Or we provide some api.

1. What you suggested (same for both)

or

2. Change init for Config object

        public init(publicLabel: String,
                    privateLabel: String,
                    operationPrompt: String?,
                    publicKeyAccessControl: SecAccessControl,
                    privateKeyAccessControl: SecAccessControl,
                    fallbackToKeychainIfSecureEnclaveIsNotAvailable: Bool)

from ellipticcurvekeypair.

I'm leaning towards second alternative

from ellipticcurvekeypair.

from ellipticcurvekeypair.

Did you otherwise find this library easy to use?

from ellipticcurvekeypair.

from ellipticcurvekeypair.

Can you try the branch frameworks? On that branch I have support for Carthage and Cocoapods as well if you rather use that. :)

Please note that the API changed slightly to this (delaying try on access control to a later point in time):

    struct Shared {
        static let keypair: EllipticCurveKeyPair.Manager = {
            let accessControl = EllipticCurveKeyPair.AccessControl(protection: kSecAttrAccessibleAfterFirstUnlockThisDeviceOnly, flags: [.userPresence, .privateKeyUsage])
            let config = EllipticCurveKeyPair.Config(
                publicLabel: "no.agens.encrypt.public",
                privateLabel: "no.agens.encrypt.private",
                operationPrompt: "Decrypt",
                publicKeyAccessControl: accessControl,
                privateKeyAccessControl: accessControl,
                fallbackToKeychainIfSecureEnclaveIsNotAvailable: true)
            return EllipticCurveKeyPair.Manager(config: config)
        }()
    }

from ellipticcurvekeypair.

from ellipticcurvekeypair.

Me too 😆 enjoy 👋

from ellipticcurvekeypair.

If you are using cocoapods it should be as easy as adding the following to your Podfile:

  pod 'EllipticCurveKeyPair', :git => 'https://github.com/agens-no/EllipticCurveKeyPair.git', :branch => 'frameworks'

from ellipticcurvekeypair.

Were you able to test this? :)

from ellipticcurvekeypair.

from ellipticcurvekeypair.

Awesome. Good to hear. Closing this issue once it is published on master and tagged.

from ellipticcurvekeypair.

Thank you for reporting this! <3

from ellipticcurvekeypair.