Code Monkey home page Code Monkey logo

Comments (8)

gallais avatar gallais commented on July 20, 2024 2

In Agda, the example

open import Data.HITs.PropTrunc (||_||)
import Data.HITs.PropTrunc as PropTrunc

can be written

open import Data.HITs.PropTrunc as PropTrunc using (||_||)

from cubical.

MatthewDaggitt avatar MatthewDaggitt commented on July 20, 2024 1

Can you send me a link to the conventions for the standard library so that I can compare?

Haha, I wish we were this organised. There is a very bare-bones skeleton of a style guide here but mostly the convention is unspoken and is enforced by either @gallais or I coming down hard on names we don't like 😆 I'll try and flesh it out a bit more in the next couple of days.

from cubical.

riaqn avatar riaqn commented on July 20, 2024 1

I think having a function named elimPropTrunc is kind of superflous when it's already in the file PropTrunc/Properties.agda. It's better to just call it elim. Then when other files import it, they can change the qualified name.

import Data.HITs.PropTrunc as PropTrunc

foo = ... PropTrunc.elim ...

This also kinds of gives a structure to the names, which is nice.

from cubical.

riaqn avatar riaqn commented on July 20, 2024 1

Speaking of qualified import, I think we should avoid unqualifed import as much as possible, except for maybe things from Core. This practice from Haskell is nice:

open import Data.HITs.PropTrunc (||_||)
import Data.HITs.PropTrunc as PropTrunc

from cubical.

mortberg avatar mortberg commented on July 20, 2024

Yes, there is currently no naming convention. It might be a good idea to follow the HoTT-Agda convention (https://github.com/HoTT/HoTT-Agda) as we wouldn't have to think about changing names when porting developments from there.

Can you send me a link to the conventions for the standard library so that I can compare?

from cubical.

mortberg avatar mortberg commented on July 20, 2024

@MatthewDaggitt Thanks! I like the stylistic choices. I think I'll use the HoTT-Agda naming conventions and the stdlib style guide for things like indentation.

from cubical.

Alizter avatar Alizter commented on July 20, 2024

I don't find the HoTT-agda convention very readable. Perhaps its due to the use of unicode, but I would prefer a convention without too much unicode. However it is also the case that some names may get too long. I read more agda than I write, so readability is a big plus for me.

from cubical.

mortberg avatar mortberg commented on July 20, 2024

Closing this now that we finally merged #451

from cubical.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.