Code Monkey home page Code Monkey logo

Comments (8)

Bossa573 avatar Bossa573 commented on July 28, 2024

hello, for all reports, please include the reference information such as PDFs, websites, etc. Thank you very much.

from phone.

tariromukute avatar tariromukute commented on July 28, 2024

hello, for all reports, please include the reference information such as PDFs, websites, etc. Thank you very much.

Hi @Bossa573, I am not sure I understand this. Do you mean the link to the application I am using the library with. Or you mean some ISO standards to documentation.

from phone.

Bossa573 avatar Bossa573 commented on July 28, 2024

any docs works, like each countries government official docs / website, wiki pages, or even 3rd party references showing your number format should be the valid mobile phone number formats.

from phone.

tariromukute avatar tariromukute commented on July 28, 2024

Ohk noted. I found the ITU portal with the documents per country, see link. I have also updated the issue with the links and page number for each set of phone numbers not being recognised.

from phone.

Bossa573 avatar Bossa573 commented on July 28, 2024
  1. for +268, I found that there's no data in the lib (https://github.com/AfterShip/phone/blob/master/src/data/country_phone_data.ts#L1633)
  2. for +267, can add '77', '78' and '79' prefix (https://github.com/AfterShip/phone/blob/master/src/data/country_phone_data.ts#L312C48-L312C50)
  3. for +265, the docs show 77, 88, 99 prefix, which match our data (https://github.com/AfterShip/phone/blob/master/src/data/country_phone_data.ts#L1211)
    image
    the doc doesn't seem to show +265-984xxxxxx is a correct format
  4. for +263, 864xxxxxxx is the range of VoIP, which does not include in our lib's scope

from phone.

tariromukute avatar tariromukute commented on July 28, 2024

Hey @Bossa573, thanks for checking the documents out.
3. How will do a further search later, maybe the document is not up to date
4. I am guessing it is possible for someone to create a WhatsApp account using VOIP, if they select the option to verify via a call. I probably have to find a work around on this one, probably for a phone number that the package undefined for phone('+263xxxxx').countryIso2?.toLowerCase() I check if the number starts with +263.

from phone.

Bossa573 avatar Bossa573 commented on July 28, 2024

https://www.npmjs.com/package/phone/v/3.1.40
handle (1) and (2)

upcoming updates for the new format, if possible please try to create the PR as well, thank you very much.

from phone.

tariromukute avatar tariromukute commented on July 28, 2024

https://www.npmjs.com/package/phone/v/3.1.40 handle (1) and (2)

upcoming updates for the new format, if possible please try to create the PR as well, thank you very much.

Thank you @Bossa573! Sure no problem, I will raise a PR for 3 or 4 depending on the information I find. Cheers.

from phone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.