Code Monkey home page Code Monkey logo

Comments (8)

dmarcos avatar dmarcos commented on June 7, 2024

Can you elaborate your use case? Seems a bit specific and it's a depart from expected behavior and A-Frame focus. Would have to be clear demand to justify maintenance.

Notice you can disable xr-mode-ui and use same code to derive your own fullscreen-mode-ui (Remove AR and VR parts). Should be easy and can publish on npm

from aframe.

dmarcos avatar dmarcos commented on June 7, 2024

Also on Mac OS you should always see fullscreen already. No WebXR support there

from aframe.

cmahnke avatar cmahnke commented on June 7, 2024

My consideration was that the code is actually already there, but it's not fleshed out yet: A extremely low hanging fruit.
Since I already tried the combination xr-mode-ui="enabled: true; enterVREnabled: false; enterAREnabled: false;" which implies the full screen functionality from my point of view, this might be even called a bug 😉.
The fall back (in case the APIs aren't there) provides the requested mode, disabling the undesired functionality manually does not.

The generalizes use case is to create a build in flat full screen mode. Maybe I should rename the issue?

The actual background (my usecase) was the fact that I had the impression that A-Frame doesn't work very well with the WebXR API Emulator. And I wanted to make sure it wont be enabled.

Since it's meant to be include in a web page it doesn't really matter what my platform is capable or not, actually I suspect users on other platforms as well.

from aframe.

dmarcos avatar dmarcos commented on June 7, 2024

What do you mean by? Not sure I understand

  The actual background (my usecase) was the fact that I had the impression that A-Frame doesn't work very well with the WebXR API emulator. And I wanted to make sure it wont be enabled.

By the way I recommend using more modern and up to date Meta WebXR emulator

xr-mode-ui component intent is just to provide VR and AR buttons and fallback to fullscreen if none of those modes are available. We can expand docs if not clear. Just a fullscreen button adds complexity and not sure if in scope.

from aframe.

cmahnke avatar cmahnke commented on June 7, 2024

Well, what I meant is just that I wanted to disable potentially / confusing (as in getting unwanted bug reports) misleading functionality.

Thanks for the hint, I'll try that one out.

Following that logic would require to remove the fall back full screen as well - it's current existence implies that it's in scope, otherwise it wouldn't be there in the fist place. It's basically about symmetry between the results of the API detection and the manual setup / parameter possibilities. So there is no need for a new button at all, just enable a possibility to force the fall back, maybe by setting enabled: true; enterVREnabled: false; enterAREnabled: false;.

from aframe.

dmarcos avatar dmarcos commented on June 7, 2024

What I mean if that if you have the emulator installed / enabled and you see the VR and AR buttons instead of fullscreen that's expected behavior since the emulator injects the WebXR API. That's a dev workflow and should not affect users. The extension can be disabled if not in use to get regular behavior

from aframe.

dmarcos avatar dmarcos commented on June 7, 2024

The more concrete question is. In what scenario you only want the fullscreen button and never the VR / AR ones?

from aframe.

dmarcos avatar dmarcos commented on June 7, 2024
enabled: true; enterVREnabled: false; enterAREnabled: false;.

The fullscreen fallback only applies if enterVREnabled and / or enterAREnabled can't be fulfilled because there's no WebXR API available in the system. If you disable the buttons fallback doesn't apply. As mention we can clarify in docs if unclear.

from aframe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.