Incorrect branch in API call bug about git-updater HOT 12 CLOSED

Is there anyway to grab this automatically from the GitHub API?

from git-updater.

I use git-flow on one of my projects, so develop is the default branch, and master is the clean branch that I'd want version checks and downloads to come from.

Compare:

• https://api.github.com/repos/GaryJones/genesis-header-nav/contents/genesis-header-nav.php (default branch, develop)
• https://api.github.com/repos/GaryJones/genesis-header-nav/contents/genesis-header-nav.php?ref=master (master)

You can see in the first one that the url in the output contains a ref=develop, so we can extrapolate that to determine the branch to download from when no "GitHub Branch: " is given.

You might also be able to spot that in this case, the content of the file is different - search on page for the string uMQ - it's in the first (develop is on version 1.1.1), but changes to uMA in the second (master is on version 1.1.0).

from git-updater.

Makes sense then to add a GitHub Branch: header and use it. After all, I did make it that way on purpose.

from git-updater.

We just need to ensure the renaming code still works. I've accidentally deleted lots of stuff testing it.

from git-updater.

There's nothing obviously hard-coded in the renaming method that references "master" - so we should be all right there.

from git-updater.

Does this commit 787b877 solve this issue?

from git-updater.

No, not quite, for two reasons (and this is why I said I'd already got code for it).

1. You need a:

if ( ! empty( $this->github_plugin['branch'] ) )
    $endpoint = add_query_arg( 'ref', $this->github_plugin['branch'], $endpoint );

...just before the return line in get_api_url() so that the remote version check is made against the right branch.

2. You're still falling back to the master branch for the download zip, instead of parsing out the url from the remote info to get the default branch name (the bit at the end of ?ref=develop).

from git-updater.

I've reverted the commit so you can make another PR. I left in the declaration for the GitHub Branch

from git-updater.

I'm working on this.

from git-updater.

You're working, I'm waiting 😉

from git-updater.

Nearly there I think.

from git-updater.

Closing in favour of #13.

from git-updater.