changedAttributes() is not consistent when setting using nested string syntax vs. passing full JSON object about backbone-nested HOT 6 CLOSED

Right, the inconsistency is definitely not good. If an entire nested object is unset, do you think each attribute needs to show up in the changedAttributes, or just the top-level one? What about when something is removed from an array? Not obvious how those would be reflected...

Anyway, created a new branch (missing-changedattrs) with your test.

from backbone-nested.

For every change, including unset, I think it's useful to have all attributes in the affected branch (every level), reflected in changedAttributes, not just the top-level one.

For item removal from an array, I guess I would do the same. I'm not sure if the removed array item would also show up in changedAttributes - I would follow whatever Backbone.js does for an ordinary removed attribute.

from backbone-nested.

Well, the difference is when a property is unset() from an object, it can appear in changedAttributes as undefined (see the Backbone test)... when remove() is called on an array, I can't think of a good way for it to show up there, since that index will now have whatever element was next.

I'll work on resolving the inconsistency, though.

from backbone-nested.

Hi.
Really appriciate your work with NestedModel.
Just wanted to check if this is somthing that you're working atm on since the tests are failing? :-) Or is there something that I can do to help?

from backbone-nested.

@borestad haven't gotten a chance to tackle it. if you want to give it a shot - which would be much appreciated - just post here and send a pull request. otherwise, will get to it asap.

from backbone-nested.

Fixed by #48.

from backbone-nested.