Better message needed prompting admin to setup Remote Site Setting for ApexUML about apex-umlcanvas HOT 6 CLOSED

Ha, we can indeed and will! 👍

from apex-umlcanvas.

@afawcett - What is your opinion about more exception classes in the ToolingAPI class?

I am working on this ticket now. Basically, it will be solved by wrapping the http.send() call in the submitRestCall(String, String, Object) method with a try catch block which will catch a System.CalloutException.

Currently, the ToolingAPI class has a single exception (ToolingAPIException). The ToolingAPIException has a distinct "purpose." It supports relaying error codes from the tooling api but it does not really support the concept of errors within the ToolingAPI Apex class and, as with this case, communication errors prior to reaching the SFDC Tooling API endpoint.

I am reluctant to use this ToolingAPIException class as the exception to be thrown here for this issue. It does not convey the errors from the SFDC Tooling API methods; it is instead a CalloutException. My reluctance comes from trying to get the ToolingAPI consumer Apex class to interpret what the exception is regarding. In this situation, the ToolingAPIException would not have ErrorResponse records.

In general, I see a potential need to segment out the exception types for the ToolingAPI class in one of three manners:

1. multiple exception classes: There could be multiple exception classes setup to handle the various types. One type would be a "general" exception. Another type would be a "Salesforce Tooling api method error." There are probably others. A distinct class (or "error contract") would allow the consuming code of the ToolingAPI service to understand when it needs to look for a list and when the issue is something else. There are obvious impacts to the ToolingAPI project and potential for changes to the exception level service contracts in that project, but it is the option that I would recommend.

2. single exception with ENUM types: Another way to approach this is to add a TYPE enum to the ToolingAPIException class and adjust the constructor. This would allow us to program a general "error type" to the exception and, through documentation, the programmer would know to look for ErrorResponses in one case and not in another.

3. make no change at all: In this case, the ToolingAPI does what it is doing now. It does not catch the System.CalloutException at all. I am not a big fan of this approach because, IMO, it violates the idea of separation of concerns. The ToolingAPI can be considered a "fine grain service". Any issues that occur in the "fine grain service" should be contained there and then the "fine grain service" should convey the appropriate message to the calling code. I do not like the idea that the calling code should also need to trap other "types of exceptions" that the "fine grain service" is not trapping. (While I am not a fan of this approach, there is an argument to be made that with enough documentation of the possibility that other, un-caught exceptions could occur, this approach could be used. I am open to debate on the topic if you are interested in pursuing this course.) Without a doubt though, this is the simplest course of action.

What are your thoughts about these options?

@dancinllama, do you have any thoughts about this discussion?

from apex-umlcanvas.

I like option 1, it's OO and the way exceptions should work, catching an exception then inspecting an enum or expecting the call to do some work is not nice. Though since all exceptions extend Exception if the caller is simply not interested they can catch this as well, and all we need to do is ensure all our exception types honour the base class needs to provide a reasonable message. So i am in favour of having another exception class basically, option 1. 👍

from apex-umlcanvas.

John, after a brief conflab with co-contributor James, it was a no brainer, your now a committer, it makes sense as the Tooling API and Apex UML are somewhat developing together. And I've been keeping both in sync as a commit into Apex UML and then into Tooling API to avoid divergence (must go see that film!).

from apex-umlcanvas.

Ah. Very cool! Thank you both for that. Cheers!

cc: @dancinllama

from apex-umlcanvas.

This has been included in v1.7.

from apex-umlcanvas.