Code Monkey home page Code Monkey logo

ninja.js's Introduction

React Interview

This project contains a simple React application to display a paginated table of users which can be filtered.

The required features are working and have already been implemented, but the implementation can be improved in many different ways.

Given the existing solution, refactor and tidy the code to what you believe would be a best implementation. The goal is to end up with a more flexible solution to be able to accommodate further required features. Focus on best practices when it comes to react/state management/clean code.

During the interview, you will be asked to take us through your changes and maybe do some live coding on the spot.

If there are things you do not get to implement because of complexiy or time shortage, mention them in your PR so we know you thought about it.

When you make a PR, write down changes you did with a small explanation why.

Run the code

To get started:

  • clone
  • yarn install
  • yarn start

To run the tests:

  • yarn run test

How to submit

  1. Fork this repo.

  2. Make a PR to your forked repo with your changes (make sure you make PR on your forked repo and not on this one - by default github will choose this repo as destination for PR)

  3. If you chose to do public repo, send us link to the PR in your forked repo. If you choose to make private repo, add davidmilo, jacobjuul and kristiandupont as collaborators and send us link to it. (We prefer public repos so it can be send internally to other front-enders fro review.)

Tips

DON'T

  • Do not rewrite code to TypeScript. Purpose of this excercise is not to see if you can rewrite code to TypeScript.
  • Do not overcomplicate the solution - real seniority comes from making complex problems simple.

DO

We like:

  • clean code
  • easy to read code
  • easy to change code
  • reusable code
  • tested code

Above concepts are open for interpretation. We want to see what they mean to you. Try to show it to us.

ninja.js's People

Contributors

jobn avatar davidmilo avatar chrisface avatar

Stargazers

Roman avatar

Watchers

James Cloos avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.