testOnly setting variable to Symbol instead of failing about envalid HOT 5 CLOSED

@af Looks good thanks!

from envalid.

Hmm, if I'm understanding correctly, the following test cases should catch this. When I try the latest version, they throw EnvMissingError as expected. Could you try them locally and confirm, or find a way to modify them so they catch this error?

https://github.com/af/envalid/blob/46beac10cb5e3b78b085bc8d11f8e3a45f1bd4b9/tests/basics.test.ts#L247-L242

from envalid.

@af Sorry, I wasn't fully clear, if NODE_ENV is not test or production, envalid will set value to testOnlySymbol and proceed normally.

I believe that the tests that you linked should be modified to this:

process.env.NODE_ENV = 'production'
expect(() => cleanEnv({ NODE_ENV: 'production' }, makeSpec(), makeSilent)).toThrow()

process.env.NODE_ENV = 'development'
// THIS DOESN'T HOLD ANYMORE
expect(() => cleanEnv({ NODE_ENV: 'development' }, makeSpec(), makeSilent)).toThrow() 
process.env.NODE_ENV = processEnv

from envalid.

@af did you have time to look into this?

from envalid.

@edosrecki Finally did, sorry about the delay! You were right, there was a bug. Could you check out #200 and let me know if it works correctly for you now?

from envalid.