Code Monkey home page Code Monkey logo

Comments (4)

shekhar-shubhendu avatar shekhar-shubhendu commented on July 18, 2024 1

@davidyuk on another thought and after discussing it with @nduchak we can do it this way:

wallet sends the supported version in the connection request (wallet.request.connect) only and if version mismatch or unsupported then SDK/aepp throws an error.

from aexs.

shekhar-shubhendu avatar shekhar-shubhendu commented on July 18, 2024

@davidyuk we're trying to be as close to the state-channels JSON-RPC API which includes version field. you can find the example here.
The version field is as you guessed is needed to store protocol version.

from aexs.

davidyuk avatar davidyuk commented on July 18, 2024

Are AEX-2 and AEX-5 somehow connected to state-channels? If it is not, I think we can make a better decision here.

from aexs.

shekhar-shubhendu avatar shekhar-shubhendu commented on July 18, 2024

it is not connected to but I would really like to keep the protocol version out of the method params as it does not makes sense to bind the version with the methods. If this breaks something we can find some other place to put it or we can remove it simply for now.

from aexs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.