[BUG] 1st argument: not an already existing atom about kaffy HOT 11 CLOSED

I'll make sure this is fixed with the next release v0.9.5

Figured what the problem is so the fix just needs to be nicely implemented.

from kaffy.

We also encounter this in production. It appears that if a server has had the Kaffy homepage/initial dashboard requested, all subsequent requests to that server will serve correctly. For servers that have not yet had the initial dashboard requested, but where a direct link to e.g. a resource index is used by a user (from elsewhere), they'll encounter this error.

In practice running across multiple hosts, this means that a user could load the dashboard successfully, click to visit a resource (which then is routed to a different host) and encounter this issue.

from kaffy.

Does this still happen with Kaffy 0.9.4?

from kaffy.

Yes. Below a stacktrace from 0.9.4

ArgumentError: errors were found at the given arguments:

  * 1st argument: not an already existing atom

  Module "erlang", in :erlang.binary_to_existing_atom/2
  File "lib/kaffy/utils.ex", line 365, in Kaffy.Utils.convert_to_atom/1
  File "lib/kaffy/utils.ex", line 361, in Kaffy.Utils.convert_to_atoms/2
  File "lib/kaffy/utils.ex", line 218, in Kaffy.Utils.get_resource/3
  File "lib/kaffy_web/controllers/resource_controller.ex", line 55, in KaffyWeb.ResourceController.index/2
  File "lib/kaffy_web/controllers/resource_controller.ex", line 1, in KaffyWeb.ResourceController.action/2
  File "lib/kaffy_web/controllers/resource_controller.ex", line 1, in KaffyWeb.ResourceController.phoenix_controller_pipeline/2
  File "lib/phoenix/router.ex", line 354, in Phoenix.Router.__call__/2

from kaffy.

Yes, can confirm. This also happens in 0.9.4

from kaffy.

I'm also running into this issue. @aesmail can you point out what the problem is? Someone else might be able to implement a fix.

In the meantime, I've worked around this by setting a module attribute with the atom in my admin module so it already exists when Kaffy calls binary_to_existing_atom.

@fix_kaffy_issue :users

from kaffy.

Thanks @aesmail.

I saw some "to existing atom" changes on the 0.9.5 branch, but I was still seeing errors when restarting the server and then visiting a deep link without first going to the dashboard. So I assume you're not quite done yet.

from kaffy.

Where are we with this? Is PR #261 still required?

from kaffy.

@ghenry #261 might fix the issue, but I'm worried about the use of String.to_atom/1. This might crash the app during runtime due to dynamically creating atoms. It might not be a big deal, but you never know. I could be a bad guy and try to hit random non-existent URLs just to crash the app.

from kaffy.

What other Elixir idioms or design pattern options are there here?

from kaffy.

For example, what do projects like https://github.com/plausible/analytics do or other projects we could look at? I'm sure it's a solved problem already?

from kaffy.