[FEATURE-REQUEST] Smarter inflector for plural forms about kaffy HOT 6 CLOSED

It's worth mentioning that Kaffy has the plural_name admin function to customize the plural form of any schema.

Having said that, I think Kaffy could be smarter in dealing with plural names out of the box.

Alternatively, since the package is licensed on MIT, perhaps a large part of it could be just pulled into Kaffy, without reinventing the wheel.

This would be my preference if we're going that route.

Please feel free to submit a PR for this 🙏🏻.

Maybe we should also consider more options and use cases.

from kaffy.

inflex seems to be the most popular and still maintained.

I'm still not sure whether it's a good idea to bring an additional dependency just so we can have better support for inflections.

Still up for discussion though.

from kaffy.

Oh, didn't know about inflex. Nice. However, I too think that pulling it as a dependency would be too much. As such, I see following options:

1. Optional support for inflex

With something like:

plural = 
  if Code.ensure_loaded?(Inflex) do
    Inflex.pluralize(term)
  else
    fallback_pluralize(term)
  end

In my experience, this works, however is very tricky to test both paths - with and without Inflex module present.

2. Support inflex via config

config :kaffy, inflector: Inflex

# and then

inflector = Application.get_env(:kaffy, :inflector, Kaffy.Inflector)
inflector.pluralize(term)

3. Not support it at all, relying on a built-in Kaffy inflector

If Kaffy should have its own inflector, again - two options:

• Pull in something almost complete, like inflectorex or inflex and have to support this code (not sure if I'm comfortable with that, seems a bit complex)
• Build something much simpler, incomplete by design, but still covering much more cases that just appending s.

from kaffy.

I think we could combine 2 things:

• Support inflex via config.
• Build something much simpler, incomplete by design, but still covering much more cases that just appending s.

I like the idea of supporting an inflection package via config because this could potentially be beneficial for other languages as well in the future.

from kaffy.

Sounds good. I'll try to create a PR soon.

from kaffy.

Closing this issue as #233 has been merged

from kaffy.