Comments (15)
Very strange. When this happens, is the screen white too?
Original comment by [email protected]
on 22 Feb 2010 at 2:58
from gource.
Nope, although insanely slow (and seems to miss updates if you pull another
window in
front) it shows the start of the sequence just fine.
Original comment by niemueller
on 22 Feb 2010 at 8:42
from gource.
It sounds like glReadPixels() is returning all white for some reason, like its
pointing at the wrong buffer, somehow.
Could you try and replace the glReadPixels call in src/ppm.cpp with:
glReadBuffer(GL_BACK);
glPixelStorei(GL_PACK_ALIGNMENT, 1);
glReadPixels(0, 0, display.width, display.height,
GL_RGB, GL_UNSIGNED_BYTE, next_pixel_ptr);
And see if that helps.
Original comment by [email protected]
on 22 Feb 2010 at 10:04
from gource.
Nope, that didn't do it. Still the same result. I have re-verified and after the
initial ASCII header there are only 0xFF values.
Original comment by niemueller
on 22 Feb 2010 at 10:51
from gource.
I guess another thing would be to check if glReadPixels is in fact setting
values to
0xFF (ie next_pixel_ptr[0] == 0xFF after call but not initially or something
like
that) and if glReadPixels() is setting an error so that glGetError() returns a
non
zero value.
It could also be that 'char' arrays (pixel1, pixel2, pixels_shared_ptr and
next_pixel_ptr) need to be changed to be 'unsigned char'.
Original comment by [email protected]
on 23 Feb 2010 at 9:19
from gource.
Can you provide some patch to try? I have also tried the (new) Fedora package,
no
success either. I have asked the package for more info, e.g. if the problem
appears
also on his box and on 32-bit
(https://bugzilla.redhat.com/show_bug.cgi?id=567559).
Original comment by niemueller
on 23 Feb 2010 at 9:34
from gource.
Ok I wrote a patch to try:
This test patch changes char to unsigned char and will print some debugging to
STDERR
each time we call glReadPixels().
This will tell us (hopefully):
- was an error set by glReadPixels(), and what was it.
- did glReadPixels() modify the input array or leave it the same.
- did glReadPixels() modify the input array to 0xFF.
Original comment by [email protected]
on 23 Feb 2010 at 10:29
Attachments:
from gource.
Tried it. Still the same result, prints the following on the screen:
glReadPixels(0, 0, 1024, 768, 6407, 5121, next_pixel_ptr)
next_pixel_ptr[0] == 0xFF (changed to 0xFF)
Anything else you want me to try?
Maybe you can also try it with the F-12 x86_64 Live CD from
http://download.fedoraproject.org/pub/fedora/linux/releases/12/Live/x86_64/Fedor
a-12-x86_64-Live.iso
on your system?
Original comment by niemueller
on 23 Feb 2010 at 12:10
from gource.
[deleted comment]
from gource.
I've got the same issue on a WinXP box.
BUT: when runned without --output-framerate the program window is just white.
Case 1) gource.exe some_log_file
Everything is just fine.
Case 2) gource.exe some_log_file --output-ppm-stream some_file
--output-framerate 25
I can see the animation in the program window, but it runs much much slower
than in
case 1, and it seems to be displaying a single white frame for a fraction of
second
every second or so.
The stream is all white frames.
Case 3) gource.exe some_log_file --output-ppm-stream some_file
The program window is all white.
Original comment by [email protected]
on 23 Feb 2010 at 2:16
from gource.
Can you try commenting out these 3 lines in FrameExporter::dump():
display.renderToTexture(screentex, display.width, display.height, GL_RGBA);
display.fullScreenQuad(true);
...
display.fullScreenQuad(false);
If this fixes it, you will see upside down images in the ppm file.
Also if this doesn't work, could you try version 0.23 from the Downloads
section as I
made a lot of changes between 0.23 and 0.24 and it may be one of those.
Cheers
Original comment by [email protected]
on 23 Feb 2010 at 8:54
from gource.
It's upside down but otherwise it contains the expected output! So how do we
get it
flipped without loosing content again?
Original comment by niemueller
on 24 Feb 2010 at 1:48
from gource.
Great, I wasn't sure if we were going to figure this out.
Can you apply this patch to the original source. It does the flip in software
now.
Original comment by [email protected]
on 24 Feb 2010 at 3:28
Attachments:
from gource.
The patch works just fine. Thank you! Will you put out a new release? Would
make the
life much easier for packagers.
Original comment by niemueller
on 27 Feb 2010 at 8:03
from gource.
Now in 0.25
Original comment by [email protected]
on 1 Mar 2010 at 1:22
- Changed state: Fixed
from gource.
Related Issues (20)
- Gource fails on OS X 10.9 HOT 3
- Unable to find git.exe? HOT 3
- Creating a custom version of gource HOT 4
- Allow localized display of date/time HOT 1
- ffmpeg gets IO errors about 3/4 way through gource PPM file HOT 8
- Question about Gource Output HOT 1
- Gource will not accept my .log HOT 8
- Version of freetype2 less than 9.0.3 error HOT 2
- Gource displays underscore as +af8- HOT 1
- It's not an issue HOT 1
- Move old captions up, display new ones at bottom HOT 1
- Git Rebase
- configure fails on systems w/o explicit /usr/lib64 (i.e. ubuntu & possibly others w/ /usr/lib/x86_64-linux-gnu/)
- what is this command line you speak of HOT 2
- Can't find git.exe. HOT 2
- Size does metter - feature request ... HOT 1
- --highlight-colour not working HOT 1
- --dir-name-depth not working reliably HOT 3
- --dir-name-depth not working reliably HOT 2
- display directory names at directory nodes, not along edges
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gource.