String "loss" being passed to metric_name() instead of loss func name about scikeras HOT 9 OPEN

This is definitely a bug. I’ll try to fix it this week, but PRs are always welcome. I’d suggest a more robust pattern (if key == “loss” or key[:4] == “val_” or similar, suggest looking into keras docs).

from scikeras.

Would you like to make a PR with a test and a fix since it sounds like you've already figured out where the problem is?

from scikeras.

I can try, though I'm not sure I'm capable of doing it lol

from scikeras.

Give it a shot! Feel free to ask questions.

from scikeras.

I am facing this exact issue as well using keras 3.0.5/tensorflow 2.16.1

from scikeras.

Looks like the issue is with how the _fit_keras_model() method in the wrappers.py file tries to filter out Keras keys. The value error seems to have changed. if you change line 535 from if "Unknown metric function" not in str(e): to if "Unknown metric function" not in str(e) and "Could not interpret metric identifier" not in str(e): it works as expected.

from scikeras.

Is someone already working on fixing this? I'm now running into it too

from scikeras.

If you're running into this issue I'd guess you're using an unsupported version of Keras (e.g. Keras 3.0). We don't pin upper versions (which is considered best practice). It's an unfortunate tradeoff you need to make as a Python maintainer.

For now you'll either need use a supported version of Keras / Tensorflow (e.g. Tensorflow 2.12.X without the standalone Keras package) or wait for #317

from scikeras.

Could you please try #317 (pip install -U 'git+https://github.com/adriangb/scikeras.git@keras-3') and see if it fixes your problem? Thanks!

from scikeras.