Uncaught TypeError: ember_new_computed.default.readOnly is not a function about ember-cli-flash HOT 12 CLOSED

This "bug" was introduced in version 1.3.2. All previous versions work fine (between 1.1.4 and 1.3.1).

from ember-cli-flash.

This issue is holding my upgrade to ember 2.0. Have others been able to upgrade ember with the latest version of the addon?

from ember-cli-flash.

I also see this error when attempting to use ember-cli-flash 1.3.4 with Ember 1.13.9. Tested with the not-yet-released 1.3.5 and still got the same error.

from ember-cli-flash.

Thanks for the report and super sorry for not following up on this earlier. I'm looking into it, hopefully @rwjblue can also chime in

from ember-cli-flash.

@poteto - Do we have a reproduction?

from ember-cli-flash.

I'm personally unable to reproduce the issue on a fresh-generated app using Ember-CLI 1.13.8, so it may be some interaction with the other dependencies of my app (and @pedrokost's). I haven't had time yet to investigate further, but I can confirm that downgrading to 1.3.1 also resolves the issue for me.

from ember-cli-flash.

What is the output of npm ls ember-new-computed?

from ember-cli-flash.

@poteto - I suspect the issue is that some other addon is including [email protected] that is overriding the version that you are using here. 1.0.0 did not provide computed.foo macros, which would explain this issue.

Work around solution for that would be to use import computed from 'ember-new-computed'; const { computed: { readOnly } } = Ember; for the other ones, but I'd like to confirm the output of npm ls ember-new-computed above and get whatever is locked to 1.0.0 fixed.

from ember-cli-flash.

@rwjblue Thanks for the pointer! It appears I was using an older version of ember-leaflet that was locked to 1.0.0. The current version no longer uses ember-new-computed at all, so I should probably upgrade and the issue will be resolved.

I'm not completely familiar with the workings of NPM, but shouldn't this kind of conflict raise an error at npm install time? If one package requires exactly 1.0.0, and another requires exactly 1.0.2, they can't both get what they want...

from ember-cli-flash.

npm allows both to be installed, and the ember-cli build pipeline is geared towards preventing duplication in the build output. This leads to the "last" addon "winning" and clobbering other versions.

from ember-cli-flash.

If we didn't do this, then you would have many versions of various deps shipped in vendor.js.

from ember-cli-flash.

This leads to the "last" addon "winning" and clobbering other versions.

That... seems incredibly danger-prone. Given it's a situation where your app is almost guaranteed to be broken, shouldn't the build process at least warn you about it? (if not outright prevent you from building the app in such a state)

from ember-cli-flash.