Comments (7)
I don't think this will solve any problems. the idea is that we read from the same storage as the function runs. and those functions can be given the correct policies to read the storage (usually, the session key is in the env).
also, the access to the storages via fetch probably needs more than just an url. e.g. it might require an authorization header.
For Adobe I/O Runtime we...
For Azure we...
not supported :-)
from helix-universal.
With a pre-signed URL, you really just need the pre-signed URL.
The problem I see is not the authentication, but that the action code itself is no longer universal but needs to conditionally load the AWS or Google client libraries, which blows up the bundle size.
from helix-universal.
action code itself is no longer universal but needs to conditionally load the AWS or Google client libraries, which blows up the bundle size.
I fear that in the future, we will have a bundle for each cloud. otherwise we cannot support ESM modules.
from helix-universal.
With a pre-signed URL, you really just need the pre-signed URL.
ah, I see:
- https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/s3-example-presigned-urls.html
- https://cloud.google.com/storage/docs/access-control/signed-urls
from helix-universal.
And the pre-signing works without an extra HTTP request, so there is no performance impact.
from helix-universal.
I'm wondering if we should just implement the signing ourselves (again: https://github.com/adobe/helix-pages/blob/prototype-three-fetchpool/assembly/request-signer.ts) so that we can sidestep the dependency issue entirely.
from helix-universal.
🎉 This issue has been resolved in version 1.6.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from helix-universal.
Related Issues (20)
- remove support for epsagon in favour of a pluggable adapter mechanism HOT 2
- Support for function invocations not made via API Gateway
- Large Response Support HOT 6
- AWS: detect and use multiValueHeaders HOT 1
- adapter: context.env should not contain process.env HOT 5
- Do not expect raw headers (@adobe/fetch) extension
- Support for functions triggered by Amazon SQS HOT 1
- make compatible with aws-sdk v3
- TypeError when creating GET/HEAD Request with non-empty body HOT 1
- OW: Rename hlx-forwarded-host header in x-forwarded host
- isBinary should also respect content-encoding (all adapters) HOT 1
- [AWS] Allow functions to force non-HTTP mode HOT 4
- it must be possible to add custom params to presignURL HOT 3
- Dependency Dashboard
- AWS: cookie header is lost... HOT 1
- AWS: switch to single parameter support via secrets manager HOT 1
- Merge context type declarations for wrappers HOT 3
- Catch SyntaxError and return 400 as well HOT 3
- Invoking AWS function without alias causes TypeError HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helix-universal.