Code Monkey home page Code Monkey logo

Comments (7)

tripodsan avatar tripodsan commented on June 20, 2024

I don't think this will solve any problems. the idea is that we read from the same storage as the function runs. and those functions can be given the correct policies to read the storage (usually, the session key is in the env).

also, the access to the storages via fetch probably needs more than just an url. e.g. it might require an authorization header.

For Adobe I/O Runtime we...
For Azure we...

not supported :-)

from helix-universal.

trieloff avatar trieloff commented on June 20, 2024

With a pre-signed URL, you really just need the pre-signed URL.

The problem I see is not the authentication, but that the action code itself is no longer universal but needs to conditionally load the AWS or Google client libraries, which blows up the bundle size.

from helix-universal.

tripodsan avatar tripodsan commented on June 20, 2024

action code itself is no longer universal but needs to conditionally load the AWS or Google client libraries, which blows up the bundle size.

I fear that in the future, we will have a bundle for each cloud. otherwise we cannot support ESM modules.

from helix-universal.

tripodsan avatar tripodsan commented on June 20, 2024

With a pre-signed URL, you really just need the pre-signed URL.

ah, I see:

from helix-universal.

trieloff avatar trieloff commented on June 20, 2024

And the pre-signing works without an extra HTTP request, so there is no performance impact.

from helix-universal.

trieloff avatar trieloff commented on June 20, 2024

I'm wondering if we should just implement the signing ourselves (again: https://github.com/adobe/helix-pages/blob/prototype-three-fetchpool/assembly/request-signer.ts) so that we can sidestep the dependency issue entirely.

from helix-universal.

github-actions avatar github-actions commented on June 20, 2024

🎉 This issue has been resolved in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from helix-universal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.