Code Monkey home page Code Monkey logo

Comments (7)

dylandepass avatar dylandepass commented on July 20, 2024

@tripod pointed out that we don't really need to publish .helix/config.json and when merging we should just pull this from preview. So I've updated this issue to only allow publish operations on .helix/headers.json. That said I can see a world where in the future were potentially we want to enable publish on other files in .helix/.

from helix-sidekick.

rofe avatar rofe commented on July 20, 2024

So basically, only .helix/config.json should be treated as a special case?

cc @tripodsan

from helix-sidekick.

tripodsan avatar tripodsan commented on July 20, 2024

So basically, only .helix/config.json should be treated as a special case?

cc @tripodsan

for now, I would just disable publish on all /.helix. we can still open it up if needed.

from helix-sidekick.

rofe avatar rofe commented on July 20, 2024

OK, that's the current status. Then I don't understand this enhancement request. 😄

from helix-sidekick.

tripodsan avatar tripodsan commented on July 20, 2024

right, I forgot that there is no publish button on the edit urls. closing as won't fix.

from helix-sidekick.

dylandepass avatar dylandepass commented on July 20, 2024

Sorry, somehow missed this convo..

.helix/config-all.json is unique to each partition as per.
https://github.com/adobe/helix-html-pipeline/blob/main/src/steps/fetch-config-all.js#L103

If we are not going to enable publish we should do something similar to what is done with preview operations on .helix/config where somehow (haven't looked) a preview results in .helix/config-all.json in the live partition being updated.

Do you agree @tripodsan?

from helix-sidekick.

tripodsan avatar tripodsan commented on July 20, 2024

I think /.helix/headers.json should also not need a publish.

from helix-sidekick.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.